From: Paul Bolle <pebolle@tiscali•nl>
To: Mathieu Olivari <mathieu@codeaurora•org>
Cc: robh+dt@kernel•org, pawel.moll@arm•com, mark.rutland@arm•com,
ijc+devicetree@hellion•org.uk, galak@codeaurora•org,
davem@davemloft•net, andrew@lunn•ch, f.fainelli@gmail•com,
linux@roeck-us•net, gang.chen.5i5j@gmail•com, jiri@resnulli•us,
leitec@staticky•com, fabf@skynet•be, alexander.h.duyck@intel•com,
pavel.nakonechny@skitlab•ru, joe@perches•com, sfeldma@gmail•com,
nbd@openwrt•org, juhosg@openwrt•org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH 1/7] net: dsa: add new driver for ar8xxx family
Date: Mon, 01 Jun 2015 10:14:34 +0200 [thread overview]
Message-ID: <1433146474.2361.18.camel@x220> (raw)
In-Reply-To: <1432863742-18427-2-git-send-email-mathieu@codeaurora.org>
Just a nit: a license mismatch.
On Thu, 2015-05-28 at 18:42 -0700, Mathieu Olivari wrote:
> --- /dev/null
> +++ b/drivers/net/dsa/ar8xxx.c
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And this states, according to include/linux/module.h, that the license
is GPL v2 or later. So I think that either the comment at the top of
this file or the ident used in the MODULE_LICENSE() macro needs to
change.
Paul Bolle
next prev parent reply other threads:[~2015-06-01 8:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 1:42 [PATCH 0/7] net: dsa: add QCA AR8xxx switch family support Mathieu Olivari
2015-05-29 1:42 ` [PATCH 3/7] net: dsa: ar8xxx: add regmap support Mathieu Olivari
2015-05-29 1:58 ` Florian Fainelli
[not found] ` <5567C7B6.5060905-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-29 2:23 ` Andrew Lunn
[not found] ` <20150529022329.GH11260-g2DYL2Zd6BY@public.gmane.org>
2015-05-29 2:36 ` Florian Fainelli
[not found] ` <5567D0BA.5020409-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-29 2:44 ` Andrew Lunn
[not found] ` <20150529024425.GI11260-g2DYL2Zd6BY@public.gmane.org>
2015-05-29 17:36 ` Mathieu Olivari
2015-05-29 17:59 ` Andrew Lunn
2015-05-30 22:38 ` Sergey Ryazanov
2015-05-29 1:42 ` [PATCH 4/7] net: dsa: add QCA tag support Mathieu Olivari
[not found] ` <1432863742-18427-1-git-send-email-mathieu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-29 1:42 ` [PATCH 1/7] net: dsa: add new driver for ar8xxx family Mathieu Olivari
[not found] ` <1432863742-18427-2-git-send-email-mathieu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-29 2:08 ` Andrew Lunn
2015-06-01 8:14 ` Paul Bolle [this message]
2015-05-29 1:42 ` [PATCH 2/7] net: dsa: ar8xxx: add ethtool hw statistics support Mathieu Olivari
2015-05-29 1:42 ` [PATCH 5/7] net: dsa: ar8xxx: enable QCA header support on AR8xxx Mathieu Olivari
2015-05-29 1:42 ` [PATCH 6/7] net: dsa: ar8xxx: add support for second xMII interfaces through DT Mathieu Olivari
2015-05-29 1:42 ` [PATCH 7/7] Documentation: devicetree: add ar8xxx binding Mathieu Olivari
[not found] ` <1432863742-18427-8-git-send-email-mathieu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-29 2:04 ` Florian Fainelli
2015-05-29 2:00 ` [PATCH 0/7] net: dsa: add QCA AR8xxx switch family support Andrew Lunn
2015-05-29 18:49 ` [PATCH 0/7] net: dsa: add QCA AR8xxx switch family support\ Mathieu Olivari
[not found] ` <20150529184951.GA2458-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-29 18:59 ` Andrew Lunn
2015-05-29 19:58 ` Florian Fainelli
[not found] ` <5568C4D4.7010701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-29 19:59 ` Mathieu Olivari
[not found] ` <20150529195955.GA2884-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-05-29 20:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433146474.2361.18.camel@x220 \
--to=pebolle@tiscali$(echo .)nl \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fabf@skynet$(echo .)be \
--cc=galak@codeaurora$(echo .)org \
--cc=gang.chen.5i5j@gmail$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=jiri@resnulli$(echo .)us \
--cc=joe@perches$(echo .)com \
--cc=juhosg@openwrt$(echo .)org \
--cc=leitec@staticky$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=mark.rutland@arm$(echo .)com \
--cc=mathieu@codeaurora$(echo .)org \
--cc=nbd@openwrt$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pavel.nakonechny@skitlab$(echo .)ru \
--cc=pawel.moll@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox