From: Ben Hutchings <ben@decadent•org.uk>
To: Jacob Keller <jacob.e.keller@intel•com>, netdev@vger•kernel.org
Cc: "David Miller" <davem@davemloft•net>,
"Michał Mirosław" <mirq-linux@rere•qmqm.pl>,
"Ben Hutchings" <bhutchings@solarflare•com>,
"Jeff Garzik" <jeff@garzik•org>,
"Alexander Duyck" <alexander.duyck@gmail•com>,
"Mark Rustad" <mark.d.rustad@intel•com>
Subject: Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats
Date: Wed, 02 Mar 2016 00:12:20 +0000 [thread overview]
Message-ID: <1456877540.3098.162.camel@decadent.org.uk> (raw)
In-Reply-To: <1456871112-14103-1-git-send-email-jacob.e.keller@intel.com>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Tue, 2016-03-01 at 14:25 -0800, Jacob Keller wrote:
> Since at least 2005, (oldest commit in ethtool.git), the userspace
> ethtool implementation has given the size of the memory it has allocated
> as the actual size in the ethtool data structures. We previously blindly
> ignore this and overwrite the requested size with the current size
> returned by .get_strings or .get_sset_count. This can cause problems if
> these values aren't static.
[...]
NAK, ethtool is not the only consumer of the ethtool API. How many
times do I have to repeat myself?
Ben.
--
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-03-02 0:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 22:25 [PATCH v2] ethtool: check size of user memory before copying strings and stats Jacob Keller
2016-03-01 22:31 ` Alexander Duyck
2016-03-01 22:58 ` Keller, Jacob E
2016-03-01 23:05 ` Alexander Duyck
2016-03-01 23:47 ` Keller, Jacob E
2016-03-02 0:12 ` Ben Hutchings [this message]
2016-03-02 1:11 ` Keller, Jacob E
2016-03-02 10:48 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456877540.3098.162.camel@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jeff@garzik$(echo .)org \
--cc=mark.d.rustad@intel$(echo .)com \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox