From: Ben Hutchings <ben@decadent•org.uk>
To: "Keller, Jacob E" <jacob.e.keller@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Cc: "davem@davemloft•net" <davem@davemloft•net>,
"bhutchings@solarflare•com" <bhutchings@solarflare•com>,
"Rustad, Mark D" <mark.d.rustad@intel•com>,
"jeff@garzik•org" <jeff@garzik•org>,
"mirq-linux@rere•qmqm.pl" <mirq-linux@rere•qmqm.pl>,
"alexander.duyck@gmail•com" <alexander.duyck@gmail•com>
Subject: Re: [PATCH v2] ethtool: check size of user memory before copying strings and stats
Date: Wed, 02 Mar 2016 10:48:02 +0000 [thread overview]
Message-ID: <1456915682.3098.164.camel@decadent.org.uk> (raw)
In-Reply-To: <1456881113.9520.24.camel@intel.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, 2016-03-02 at 01:11 +0000, Keller, Jacob E wrote:
> On Wed, 2016-03-02 at 00:12 +0000, Ben Hutchings wrote:
> > NAK, ethtool is not the only consumer of the ethtool API. How many
> > times do I have to repeat myself?
> >
> > Ben.
> >
>
> Ok, so essentially forcing drivers to require static sets for the
> various stats/strings/etc?
No, you can define a new and better statistics API. There are many
limitations of the current API that could be addressed at the same
time, e.g. lack of units, lack of hierarchy in naming, lack of
distinction between counters and other statistics.
Ben.
> :(
>
> Will have patches to cleanup fm10k for this then.
>
> Regards,
> Jake
--
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2016-03-02 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 22:25 [PATCH v2] ethtool: check size of user memory before copying strings and stats Jacob Keller
2016-03-01 22:31 ` Alexander Duyck
2016-03-01 22:58 ` Keller, Jacob E
2016-03-01 23:05 ` Alexander Duyck
2016-03-01 23:47 ` Keller, Jacob E
2016-03-02 0:12 ` Ben Hutchings
2016-03-02 1:11 ` Keller, Jacob E
2016-03-02 10:48 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456915682.3098.164.camel@decadent.org.uk \
--to=ben@decadent$(echo .)org.uk \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jeff@garzik$(echo .)org \
--cc=mark.d.rustad@intel$(echo .)com \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox