From: Joe Perches <joe@perches•com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel•com>, davem@davemloft•net
Cc: Don Skidmore <donald.c.skidmore@intel•com>,
netdev@vger•kernel.org, nhorman@redhat•com, sassmann@redhat•com,
jogreene@redhat•com, guru.anbalagane@oracle•com
Subject: Re: [net-next 14/14] ixgbe: cleanup crosstalk fix
Date: Sat, 23 Jul 2016 10:38:59 -0700 [thread overview]
Message-ID: <1469295539.1900.166.camel@perches.com> (raw)
In-Reply-To: <1469256591-109822-15-git-send-email-jeffrey.t.kirsher@intel.com>
On Fri, 2016-07-22 at 23:49 -0700, Jeff Kirsher wrote:
> From: Don Skidmore <donald.c.skidmore@intel•com>
>
> This patch address a few issues with the initial crosstalk fix. Most
> important of which is the SDP that indicates the presents of a SFP+
> module changes between HW types. With this change that is taken in
> to consideration
[]
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
[]
> @@ -301,6 +302,22 @@ s32 ixgbe_start_hw_generic(struct ixgbe_hw *hw)
> if (ret_val)
> return ret_val;
>
> + /* Cashe bit indicating need for crosstalk fix */
spello: cache
> + switch (hw->mac.type) {
> + case ixgbe_mac_82599EB:
> + case ixgbe_mac_X550EM_x:
> + case ixgbe_mac_x550em_a:
> + hw->mac.ops.get_device_caps(hw, &device_caps);
> + if (device_caps & IXGBE_DEVICE_CAPS_NO_CROSSTALK_WR)
> + hw->need_crosstalk_fix = false;
> + else
> + hw->need_crosstalk_fix = true;
could be
hw->need_crosstalk_fix = !(device_caps & IXGBE_DEVICE_CAPS_NO_CROSSTALK_WR);
next prev parent reply other threads:[~2016-07-23 17:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-23 6:49 [net-next 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-07-22 Jeff Kirsher
2016-07-23 6:49 ` [net-next 01/14] ixgbevf: fix NACK check in ixgbevf_set_uc_addr_vf() Jeff Kirsher
2016-07-23 6:49 ` [net-next 02/14] ixgbevf: Correct parameter sent to LED function Jeff Kirsher
2016-07-23 6:49 ` [net-next 03/14] ixgbevf: bump version number Jeff Kirsher
2016-07-23 6:49 ` [net-next 04/14] ixgbe: Change register variable to unsigned Jeff Kirsher
2016-07-23 6:49 ` [net-next 05/14] ixgbe: Fix minor typo while freeing irq Jeff Kirsher
2016-07-23 6:49 ` [net-next 06/14] ixgbevf: add VF support for new hardware Jeff Kirsher
2016-07-23 6:49 ` [net-next 07/14] ixgbe: fix setup_fc for x550em Jeff Kirsher
2016-07-23 6:49 ` [net-next 08/14] ixgbevf: Add lock around ixgbevf_reinit_locked call Jeff Kirsher
2016-07-23 6:49 ` [net-next 09/14] ixgbe: Add missing destroy_workqueue() on error in ixgbe_init_module() Jeff Kirsher
2016-07-23 6:49 ` [net-next 10/14] ixgbevf: Protect ixgbevf_reset_subtask from remove event Jeff Kirsher
2016-07-23 6:49 ` [net-next 11/14] ixgbevf: Add range checking for setting MTU Jeff Kirsher
2016-07-23 6:49 ` [net-next 12/14] ixgbevf: Commonize mailbox write/read Jeff Kirsher
2016-07-23 6:49 ` [net-next 13/14] ixgbe: remove redundant check on ret_val Jeff Kirsher
2016-07-23 6:49 ` [net-next 14/14] ixgbe: cleanup crosstalk fix Jeff Kirsher
2016-07-23 17:38 ` Joe Perches [this message]
2016-07-25 18:28 ` [net-next 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-07-22 David Miller
2016-07-25 20:27 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469295539.1900.166.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=guru.anbalagane@oracle$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jogreene@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox