From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>
To: Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
luto-kltTT9wpgjJwATOyAt5JVQ@public•gmane.org,
sergey.senozhatsky.work-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public•gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org, j@w1•fi
Subject: Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack
Date: Fri, 14 Oct 2016 15:10:35 +0200 [thread overview]
Message-ID: <1476450635.31114.42.camel@sipsolutions.net> (raw)
In-Reply-To: <1476450540-1760-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (sfid-20161014_150908_308224_F47D6BD7)
> So use kzalloc
Do we really need kzalloc()? We have things on the stack right now, and
don't initialize, so surely we don't really need to zero things?
> This only addresses one half of the problem. The other problem, i.e.,
> the fact that the aad[] array lives on the stack of the caller, is
> handled adequately imo by the change proposed by Johannes.
But if we allocate things anyway, is it worth expending per-CPU buffers
on these?
johannes
next prev parent reply other threads:[~2016-10-14 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 13:09 [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel
[not found] ` <1476450540-1760-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-14 13:10 ` Johannes Berg [this message]
2016-10-14 13:11 ` Johannes Berg
[not found] ` <1476450635.31114.42.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-14 13:13 ` Ard Biesheuvel
2016-10-14 13:15 ` Johannes Berg
2016-10-14 13:19 ` Ard Biesheuvel
2016-10-14 13:46 ` Johannes Berg
[not found] ` <1476452792.31114.46.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-14 14:22 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476450635.31114.42.camel@sipsolutions.net \
--to=johannes-cdvu00un1vgdhxzaddlk8q@public$(echo .)gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public$(echo .)gmane.org \
--cc=j@w1$(echo .)fi \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sergey.senozhatsky.work-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox