From: Johannes Berg <johannes@sipsolutions•net>
To: Ard Biesheuvel <ard.biesheuvel@linaro•org>,
luto@amacapital•net, sergey.senozhatsky.work@gmail•com,
netdev@vger•kernel.org, herbert@gondor•apana.org.au,
davem@davemloft•net, linux-wireless@vger•kernel.org,
linux-kernel@vger•kernel.org, j@w1•fi
Subject: Re: [PATCH] mac80211: aes_ccm: move struct aead_req off the stack
Date: Fri, 14 Oct 2016 15:11:18 +0200 [thread overview]
Message-ID: <1476450678.31114.43.camel@sipsolutions.net> (raw)
In-Reply-To: <1476450635.31114.42.camel@sipsolutions.net> (sfid-20161014_151049_007103_7C55AE25)
On Fri, 2016-10-14 at 15:10 +0200, Johannes Berg wrote:
> >
> > So use kzalloc
>
> Do we really need kzalloc()? We have things on the stack right now,
> and don't initialize, so surely we don't really need to zero things?
Err, never mind, I'm an idiot - we *do* initialize to 0, of course.
johannes
next prev parent reply other threads:[~2016-10-14 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 13:09 [PATCH] mac80211: aes_ccm: move struct aead_req off the stack Ard Biesheuvel
[not found] ` <1476450540-1760-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-14 13:10 ` Johannes Berg
2016-10-14 13:11 ` Johannes Berg [this message]
[not found] ` <1476450635.31114.42.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-14 13:13 ` Ard Biesheuvel
2016-10-14 13:15 ` Johannes Berg
2016-10-14 13:19 ` Ard Biesheuvel
2016-10-14 13:46 ` Johannes Berg
[not found] ` <1476452792.31114.46.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-10-14 14:22 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476450678.31114.43.camel@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=j@w1$(echo .)fi \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergey.senozhatsky.work@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox