From: Johan Hovold <johan@kernel•org>
To: "David S. Miller" <davem@davemloft•net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>,
Alexandre Torgue <alexandre.torgue@st•com>,
Joachim Eastwood <manabian@gmail•com>,
Carlo Caione <carlo@caione•org>,
Kevin Hilman <khilman@baylibre•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Maxime Ripard <maxime.ripard@free-electrons•com>,
Chen-Yu Tsai <wens@csie•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Johan Hovold <johan@kernel•org>
Subject: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks
Date: Wed, 30 Nov 2016 15:29:48 +0100 [thread overview]
Message-ID: <1480516195-27696-1-git-send-email-johan@kernel.org> (raw)
This series fixes a number of issues with the stmmac-driver probe error
handling, which for example left clocks enabled after probe failures.
The final patch fixes a failure to deregister and free any fixed-link
PHYs that were registered during probe on probe errors and on driver
unbind. It also fixes a related of-node leak on late probe errors.
This series depends on the of_phy_deregister_fixed_link() helper that
was just merged to net.
As mentioned earlier, one staging driver also suffers from a similar
leak and can be fixed up once the above mentioned helper hits mainline.
Note that these patches have only been compile tested.
Johan
Johan Hovold (7):
net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe
errors
net: ethernet: stmmac: dwmac-sti: fix probe error path
net: ethernet: stmmac: dwmac-rk: fix probe error path
net: ethernet: stmmac: dwmac-generic: fix probe error path
net: ethernet: stmmac: dwmac-meson8b: fix probe error path
net: ethernet: stmmac: platform: fix outdated function header
net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks
.../net/ethernet/stmicro/stmmac/dwmac-generic.c | 17 ++++++++--
.../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 25 ++++++++++----
.../net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 17 ++++++++--
drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 23 ++++++++++---
.../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 32 +++++++++++++-----
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 21 +++++++++---
.../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 39 ++++++++++++++--------
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 23 ++++++++++---
drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 19 ++++++++---
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 26 +++++++++++----
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 -
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 33 +++++++++++++++---
.../net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 ++
13 files changed, 215 insertions(+), 63 deletions(-)
--
2.7.3
next reply other threads:[~2016-11-30 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 14:29 Johan Hovold [this message]
2016-11-30 14:29 ` [PATCH net 1/7] net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe errors Johan Hovold
2016-11-30 14:29 ` [PATCH net 2/7] net: ethernet: stmmac: dwmac-sti: fix probe error path Johan Hovold
2016-11-30 14:29 ` [PATCH net 3/7] net: ethernet: stmmac: dwmac-rk: " Johan Hovold
2016-11-30 14:29 ` [PATCH net 4/7] net: ethernet: stmmac: dwmac-generic: " Johan Hovold
2016-11-30 14:29 ` [PATCH net 5/7] net: ethernet: stmmac: dwmac-meson8b: " Johan Hovold
2016-11-30 16:43 ` Kevin Hilman
2016-11-30 14:29 ` [PATCH net 6/7] net: ethernet: stmmac: platform: fix outdated function header Johan Hovold
2016-11-30 14:29 ` [PATCH net 7/7] net: ethernet: stmmac: fix of-node and fixed-link-phydev leaks Johan Hovold
2016-11-30 14:39 ` Maxime Ripard
2016-12-02 8:46 ` [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks Giuseppe CAVALLARO
2016-12-02 15:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480516195-27696-1-git-send-email-johan@kernel.org \
--to=johan@kernel$(echo .)org \
--cc=alexandre.torgue@st$(echo .)com \
--cc=carlo@caione$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=khilman@baylibre$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manabian@gmail$(echo .)com \
--cc=maxime.ripard@free-electrons$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox