From: Joe Perches <joe@perches•com>
To: Gavin Shan <gwshan@linux•vnet.ibm.com>, netdev@vger•kernel.org
Cc: davem@davemloft•net
Subject: Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics
Date: Thu, 13 Apr 2017 03:50:40 -0700 [thread overview]
Message-ID: <1492080640.28586.15.camel@perches.com> (raw)
In-Reply-To: <1492069701-20772-6-git-send-email-gwshan@linux.vnet.ibm.com>
On Thu, 2017-04-13 at 17:48 +1000, Gavin Shan wrote:
> This creates /sys/kernel/debug/ncsi/<eth0>/stats to dump the NCSI
> packets sent and received over all packages and channels. It's useful
> to diagnose NCSI problems, especially when NCSI packages and channels
> aren't probed properly.
trivia:
> diff --git a/net/ncsi/ncsi-debug.c b/net/ncsi/ncsi-debug.c
> index 6c00e9b..29c233c 100644
> --- a/net/ncsi/ncsi-debug.c
> +++ b/net/ncsi/ncsi-debug.c
> @@ -23,6 +23,235 @@
> #include "ncsi-pkt.h"
>
> static struct dentry *ncsi_dentry;
> +static struct ncsi_pkt_handler {
static const struct etc...
> + unsigned char type;
> + const char *name;
> +} ncsi_pkt_handlers[] = {
> + { NCSI_PKT_CMD_CIS, "CIS" },
[]
> +static bool ncsi_dev_stats_index(struct ncsi_dev_priv *ndp, loff_t pos,
> + unsigned long *type, unsigned long *index,
> + unsigned long *entries)
> +{
> + int i;
> + unsigned long ranges[3][2] = {
> + { 1,
> + ARRAY_SIZE(ndp->stats.cmd) - 1 },
> + { ranges[0][1] + 2,
> + ranges[1][0] + ARRAY_SIZE(ndp->stats.rsp) - 1 },
> + { ranges[1][1] + 2,
> + ranges[2][0] + ARRAY_SIZE(ndp->stats.aen) - 1 }
> + };
const?
next prev parent reply other threads:[~2017-04-13 10:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 7:48 [PATCH v2 net-next 0/8] net/ncsi: Add debugging functionality Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 1/8] net/ncsi: Disable HWA mode when no channels are found Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 2/8] net/ncsi: Properly track channel monitor timer state Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 3/8] net/ncsi: Enforce failover on link monitor timeout Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 4/8] net/ncsi: Add debugging infrastructurre Gavin Shan
2017-04-13 10:41 ` Joe Perches
2017-04-17 23:22 ` Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics Gavin Shan
2017-04-13 10:50 ` Joe Perches [this message]
2017-04-17 23:23 ` Gavin Shan
2017-04-14 1:50 ` Jakub Kicinski
2017-04-18 0:14 ` Gavin Shan
2017-04-14 2:30 ` Joe Perches
2017-04-18 0:22 ` Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 6/8] net/ncsi: Support NCSI packet generation Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 7/8] net/ncsi: No error report on DP response to non-existing package Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 8/8] net/ncsi: Fix length of GVI response packet Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492080640.28586.15.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox