From: Jakub Kicinski <kubakici@wp•pl>
To: Gavin Shan <gwshan@linux•vnet.ibm.com>
Cc: netdev@vger•kernel.org, joe@perches•com, davem@davemloft•net
Subject: Re: [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics
Date: Thu, 13 Apr 2017 18:50:42 -0700 [thread overview]
Message-ID: <20170413185042.0e69cb71@cakuba.lan> (raw)
In-Reply-To: <1492069701-20772-6-git-send-email-gwshan@linux.vnet.ibm.com>
Hi!
On Thu, 13 Apr 2017 17:48:18 +1000, Gavin Shan wrote:
> This creates /sys/kernel/debug/ncsi/<eth0>/stats to dump the NCSI
> packets sent and received over all packages and channels. It's useful
> to diagnose NCSI problems, especially when NCSI packages and channels
> aren't probed properly. The statistics can be gained from debugfs file
> as below:
>
> # cat /sys/kernel/debug/ncsi/eth0/stats
>
> CMD OK TIMEOUT ERROR
> =======================================
> CIS 32 29 0
> SP 10 7 0
> DP 17 14 0
> EC 1 0 0
> ECNT 1 0 0
> AE 1 0 0
> GLS 11 0 0
> SMA 1 0 0
> EBF 1 0 0
> GVI 2 0 0
> GC 2 0 0
>
> RSP OK TIMEOUT ERROR
> =======================================
> CIS 3 0 0
> SP 3 0 0
> DP 2 0 1
> EC 1 0 0
> ECNT 1 0 0
> AE 1 0 0
> GLS 11 0 0
> SMA 1 0 0
> EBF 1 0 0
> GVI 0 0 2
> GC 2 0 0
>
> AEN OK TIMEOUT ERROR
> =======================================
>
> Signed-off-by: Gavin Shan <gwshan@linux•vnet.ibm.com>
I'm not familiar with NC-SI but these look like some standard stats.
Would it make sense to provide a proper netlink API for them?
[...]
> +#ifdef CONFIG_NET_NCSI_DEBUG
> + ndp->stats.aen[h->type][NCSI_PKT_STAT_ERROR]++;
> +#endif
In any case, did you consider creating a macro or inline helper to
limit the number of #ifdefs?
next prev parent reply other threads:[~2017-04-14 1:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 7:48 [PATCH v2 net-next 0/8] net/ncsi: Add debugging functionality Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 1/8] net/ncsi: Disable HWA mode when no channels are found Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 2/8] net/ncsi: Properly track channel monitor timer state Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 3/8] net/ncsi: Enforce failover on link monitor timeout Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 4/8] net/ncsi: Add debugging infrastructurre Gavin Shan
2017-04-13 10:41 ` Joe Perches
2017-04-17 23:22 ` Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 5/8] net/ncsi: Dump NCSI packet statistics Gavin Shan
2017-04-13 10:50 ` Joe Perches
2017-04-17 23:23 ` Gavin Shan
2017-04-14 1:50 ` Jakub Kicinski [this message]
2017-04-18 0:14 ` Gavin Shan
2017-04-14 2:30 ` Joe Perches
2017-04-18 0:22 ` Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 6/8] net/ncsi: Support NCSI packet generation Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 7/8] net/ncsi: No error report on DP response to non-existing package Gavin Shan
2017-04-13 7:48 ` [PATCH v2 net-next 8/8] net/ncsi: Fix length of GVI response packet Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413185042.0e69cb71@cakuba.lan \
--to=kubakici@wp$(echo .)pl \
--cc=davem@davemloft$(echo .)net \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=joe@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox