From: Johannes Berg <johannes@sipsolutions•net>
To: Kalle Valo <kvalo@qca•qualcomm.com>,
Bjorn Andersson <bjorn.andersson@linaro•org>
Cc: "k.eugene.e@gmail•com" <k.eugene.e@gmail•com>,
Andy Gross <andy.gross@linaro•org>,
David Brown <david.brown@linaro•org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-arm-msm@vger•kernel.org" <linux-arm-msm@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-soc@vger•kernel.org" <linux-soc@vger•kernel.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"wcn36xx@lists•infradead.org" <wcn36xx@lists•infradead.org>,
"nicolas.dechesne@linaro•org" <nicolas.dechesne@linaro•org>
Subject: Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()
Date: Wed, 17 May 2017 15:14:27 +0200 [thread overview]
Message-ID: <1495026867.2442.9.camel@sipsolutions.net> (raw)
In-Reply-To: <87fugkrchl.fsf@kamboji.qca.qualcomm.com>
On Thu, 2017-05-04 at 13:13 +0000, Kalle Valo wrote:
>
> > > This code intentionally checked if TX status was requested, and
> > > if not then it doesn't go to the effort of building it.
> > >
> >
> > What I'm finding puzzling is the fact that the only caller of
> > ieee80211_led_tx() is ieee80211_tx_status() and it seems like
> > drivers, such as ath10k, call this for each packet handled - but
> > I'm likely missing something.
Yes, many drivers do call it for each packet, and as such, this
deficiency was never noted.
> > > As it is with your patch, it'll go and report the TX status
> > > without any
> > > TX status information - which is handled in
> > > wcn36xx_dxe_tx_ack_ind()
> > > for those frames needing it.
> > >
> >
> > Right, it doesn't sound desired. However, during normal operation
> > I'm not seeing IEEE80211_TX_CTL_REQ_TX_STATUS being set and as such
> > ieee80211_led_tx() is never called.
>
> So what's the conclusion? How do we get leds working?
Well, frankly, I never thought the TX LED was a super good idea - but
it had been supported by the original code IIRC, so never removed. Some
people like frantic blinking I guess ;-)
But I think the problem also applies to the throughput trigger thing,
so perhaps we need to stick some LED feedback calls into other places,
like _noskb() or provide an extra way to do it?
johannes
next prev parent reply other threads:[~2017-05-17 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 22:04 [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Bjorn Andersson
2017-04-26 22:04 ` [PATCH 2/2] arm64: dts: apq8016-sbc: Correct WLAN LED default-trigger Bjorn Andersson
[not found] ` <20170426220444.10539-1-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-04-27 8:22 ` [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Johannes Berg
[not found] ` <1493281332.2529.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-28 23:42 ` Bjorn Andersson
2017-05-04 13:13 ` Kalle Valo
2017-05-17 13:14 ` Johannes Berg [this message]
2017-05-18 5:05 ` Bjorn Andersson
2017-05-18 7:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495026867.2442.9.camel@sipsolutions.net \
--to=johannes@sipsolutions$(echo .)net \
--cc=andy.gross@linaro$(echo .)org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=david.brown@linaro$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=k.eugene.e@gmail$(echo .)com \
--cc=kvalo@qca$(echo .)qualcomm.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-soc@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dechesne@linaro$(echo .)org \
--cc=wcn36xx@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox