From: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public•gmane.org>
To: Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public•gmane.org>,
"k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org"
<k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
David Brown <david.brown-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org>,
"linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-soc-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-soc-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org"
<wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public•gmane.org>,
"nicolas.dechesne-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org"
<nicolas.dechesne-QSEj5FYQhm4dnm+yROfE0A@public•gmane.org>
Subject: Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()
Date: Thu, 4 May 2017 13:13:43 +0000 [thread overview]
Message-ID: <87fugkrchl.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170428234247.GQ15143@minitux> (Bjorn Andersson's message of "Fri, 28 Apr 2017 16:42:47 -0700")
Bjorn Andersson <bjorn.andersson@linaro•org> writes:
> On Thu 27 Apr 01:22 PDT 2017, Johannes Berg wrote:
>
>>
>> > @@ -371,7 +371,7 @@ static void reap_tx_dxes(struct wcn36xx *wcn,
>> > struct wcn36xx_dxe_ch *ch)
>> > info = IEEE80211_SKB_CB(ctl->skb);
>> > if (!(info->flags &
>> > IEEE80211_TX_CTL_REQ_TX_STATUS)) {
>> > /* Keep frame until TX status comes
>> > */
>> > - ieee80211_free_txskb(wcn->hw, ctl-
>> > >skb);
>> > + ieee80211_tx_status(wcn->hw, ctl-
>> > >skb);
>> >
>>
>> I don't think this is a good idea.
>
> Thanks for letting me know :)
>
>> This code intentionally checked if TX status was requested, and if not
>> then it doesn't go to the effort of building it.
>>
>
> What I'm finding puzzling is the fact that the only caller of
> ieee80211_led_tx() is ieee80211_tx_status() and it seems like drivers,
> such as ath10k, call this for each packet handled - but I'm likely
> missing something.
>
>> As it is with your patch, it'll go and report the TX status without any
>> TX status information - which is handled in wcn36xx_dxe_tx_ack_ind()
>> for those frames needing it.
>>
>
> Right, it doesn't sound desired. However, during normal operation I'm
> not seeing IEEE80211_TX_CTL_REQ_TX_STATUS being set and as such
> ieee80211_led_tx() is never called.
So what's the conclusion? How do we get leds working?
--
Kalle Valo
next prev parent reply other threads:[~2017-05-04 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 22:04 [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Bjorn Andersson
2017-04-26 22:04 ` [PATCH 2/2] arm64: dts: apq8016-sbc: Correct WLAN LED default-trigger Bjorn Andersson
[not found] ` <20170426220444.10539-1-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-04-27 8:22 ` [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Johannes Berg
[not found] ` <1493281332.2529.1.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-28 23:42 ` Bjorn Andersson
2017-05-04 13:13 ` Kalle Valo [this message]
2017-05-17 13:14 ` Johannes Berg
2017-05-18 5:05 ` Bjorn Andersson
2017-05-18 7:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fugkrchl.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-a+znkfmmk5xy9ajcnzt0uw@public$(echo .)gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public$(echo .)gmane.org \
--cc=k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=nicolas.dechesne-QSEj5FYQhm4dnm+yROfE0A@public$(echo .)gmane.org \
--cc=wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox