* [PATCH net] Revert "rtnetlink: Do not generate notifications for CHANGEADDR event"
@ 2017-07-19 17:22 David Ahern
0 siblings, 0 replies; only message in thread
From: David Ahern @ 2017-07-19 17:22 UTC (permalink / raw)
To: netdev; +Cc: yaroslav.isakov, David Ahern
This reverts commit cd8966e75ed3c6b41a37047a904617bc44fa481f.
The duplicate CHANGEADDR event message is sent regardless of link
status whereas the setlink changes only generate a notification when
the link is up. Not sending a notification when the link is down breaks
dhcpcd which only processes hwaddr changes when the link is down.
Fixes reported regression:
https://bugzilla.kernel.org/show_bug.cgi?id=196355
Reported-by: Yaroslav Isakov <yaroslav.isakov@gmail•com>
Signed-off-by: David Ahern <dsahern@gmail•com>
---
net/core/rtnetlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index d1ba90980be1..11b25fbf3dd2 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -4241,6 +4241,7 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
switch (event) {
case NETDEV_REBOOT:
+ case NETDEV_CHANGEADDR:
case NETDEV_CHANGENAME:
case NETDEV_FEAT_CHANGE:
case NETDEV_BONDING_FAILOVER:
--
2.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-19 17:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-19 17:22 [PATCH net] Revert "rtnetlink: Do not generate notifications for CHANGEADDR event" David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox