public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

* [PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery
@ 2021-02-14 16:38 Heiner Kallweit
  2021-02-15 20:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2021-02-14 16:38 UTC (permalink / raw)
  To: Jakub Kicinski, David Miller, Realtek linux nic maintainers
  Cc: netdev@vger•kernel.org

Armin reported that after referenced commit his RTL8105e is dead when
resuming from suspend and machine runs on battery. This patch has been
confirmed to fix the issue.

Fixes: e80bd76fbf56 ("r8169: work around power-saving bug on some chip versions")
Reported-by: Armin Wolf <W_Armin@gmx•de>
Tested-by: Armin Wolf <W_Armin@gmx•de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail•com>
---
- This fix applies on net-next. For net I submitted a separate patch.
---
 drivers/net/ethernet/realtek/r8169_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 04231585e..376dfd011 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -1252,6 +1252,7 @@ static void rtl_set_d3_pll_down(struct rtl8169_private *tp, bool enable)
 {
 	switch (tp->mac_version) {
 	case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26:
+	case RTL_GIGA_MAC_VER_29 ... RTL_GIGA_MAC_VER_30:
 	case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_37:
 	case RTL_GIGA_MAC_VER_39 ... RTL_GIGA_MAC_VER_63:
 		if (enable)
-- 
2.30.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

• * Re: [PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery
    2021-02-14 16:38 [PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery Heiner Kallweit
  @ 2021-02-15 20:40 ` patchwork-bot+netdevbpf
    0 siblings, 0 replies; 2+ messages in thread
  From: patchwork-bot+netdevbpf @ 2021-02-15 20:40 UTC (permalink / raw)
    To: Heiner Kallweit; +Cc: kuba, davem, nic_swsd, netdev
  
  Hello:
  
  This patch was applied to netdev/net-next.git (refs/heads/master):
  
  On Sun, 14 Feb 2021 17:38:30 +0100 you wrote:
  > Armin reported that after referenced commit his RTL8105e is dead when
  > resuming from suspend and machine runs on battery. This patch has been
  > confirmed to fix the issue.
  > 
  > Fixes: e80bd76fbf56 ("r8169: work around power-saving bug on some chip versions")
  > Reported-by: Armin Wolf <W_Armin@gmx•de>
  > Tested-by: Armin Wolf <W_Armin@gmx•de>
  > Signed-off-by: Heiner Kallweit <hkallweit1@gmail•com>
  > 
  > [...]
  
  Here is the summary with links:
    - [net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery
      https://git.kernel.org/netdev/net-next/c/d2a04370817f
  
  You are awesome, thank you!
  --
  Deet-doot-dot, I am a bot.
  https://korg.docs.kernel.org/patchwork/pwbot.html
  
  
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-15 20:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-14 16:38 [PATCH net-next] r8169: fix resuming from suspend on RTL8105e if machine runs on battery Heiner Kallweit
2021-02-15 20:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox