From: patchwork-bot+netdevbpf@kernel•org
To: Xin Long <lucien.xin@gmail•com>
Cc: netdev@vger•kernel.org, tipc-discussion@lists•sourceforge.net,
davem@davemloft•net, kuba@kernel•org, jmaloy@redhat•com,
ying.xue@windriver•com
Subject: Re: [PATCH net] tipc: skb_linearize the head skb when reassembling msgs
Date: Mon, 17 May 2021 20:50:10 +0000 [thread overview]
Message-ID: <162128461002.31061.4134392433331126815.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <c7d752b5522360de0a6886202c59fe49524a9fda.1620417423.git.lucien.xin@gmail.com>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 8 May 2021 03:57:03 +0800 you wrote:
> It's not a good idea to append the frag skb to a skb's frag_list if
> the frag_list already has skbs from elsewhere, such as this skb was
> created by pskb_copy() where the frag_list was cloned (all the skbs
> in it were skb_get'ed) and shared by multiple skbs.
>
> However, the new appended frag skb should have been only seen by the
> current skb. Otherwise, it will cause use after free crashes as this
> appended frag skb are seen by multiple skbs but it only got skb_get
> called once.
>
> [...]
Here is the summary with links:
- [net] tipc: skb_linearize the head skb when reassembling msgs
https://git.kernel.org/netdev/net/c/b7df21cf1b79
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-05-17 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 19:57 [PATCH net] tipc: skb_linearize the head skb when reassembling msgs Xin Long
2021-05-15 22:57 ` Jon Maloy
2021-05-17 20:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162128461002.31061.4134392433331126815.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jmaloy@redhat$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox