From: patchwork-bot+netdevbpf@kernel•org
To: Sukadev Bhattiprolu <sukadev@linux•ibm.com>
Cc: netdev@vger•kernel.org, brking@linux•ibm.com, drt@linux•ibm.com,
abdhalee@in•ibm.com, vaish123@in•ibm.com
Subject: Re: [PATCH net 1/3] ibmvnic: don't stop queue in xmit
Date: Mon, 01 Nov 2021 13:20:07 +0000 [thread overview]
Message-ID: <163577280797.31246.172894097034323578.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20211029220316.2003519-1-sukadev@linux.ibm.com>
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft•net>:
On Fri, 29 Oct 2021 15:03:14 -0700 you wrote:
> If adapter's resetting bit is on, discard the packet but don't stop the
> transmit queue - instead leave that to the reset code. With this change,
> it is possible that we may get several calls to ibmvnic_xmit() that simply
> discard packets and return.
>
> But if we stop the queue here, we might end up doing so just after
> __ibmvnic_open() started the queues (during a hard/soft reset) and before
> the ->resetting bit was cleared. If that happens, there will be no one to
> restart queue and transmissions will be blocked indefinitely.
>
> [...]
Here is the summary with links:
- [net,1/3] ibmvnic: don't stop queue in xmit
https://git.kernel.org/netdev/net/c/8878e46fcfd4
- [net,2/3] ibmvnic: Process crqs after enabling interrupts
https://git.kernel.org/netdev/net/c/6e20d00158f3
- [net,3/3] ibmvnic: delay complete()
https://git.kernel.org/netdev/net/c/6b278c0cb378
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-11-01 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 22:03 [PATCH net 1/3] ibmvnic: don't stop queue in xmit Sukadev Bhattiprolu
2021-10-29 22:03 ` [PATCH net 2/3] ibmvnic: Process crqs after enabling interrupts Sukadev Bhattiprolu
2021-10-29 22:23 ` Dany Madden
2021-10-29 22:03 ` [PATCH net 3/3] ibmvnic: delay complete() Sukadev Bhattiprolu
2021-10-29 22:25 ` Dany Madden
2021-10-29 22:18 ` [PATCH net 1/3] ibmvnic: don't stop queue in xmit Dany Madden
2021-11-01 13:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163577280797.31246.172894097034323578.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=abdhalee@in$(echo .)ibm.com \
--cc=brking@linux$(echo .)ibm.com \
--cc=drt@linux$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sukadev@linux$(echo .)ibm.com \
--cc=vaish123@in$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox