* Re: [PATCH -next] can: flexcan: Switch to use dev_err_probe() helper
2022-09-14 13:40 [PATCH -next] can: flexcan: Switch to use dev_err_probe() helper Yang Yingliang
@ 2022-09-14 13:38 ` Marc Kleine-Budde
2022-09-17 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2022-09-14 13:38 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-can, netdev, wg
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
On 14.09.2022 21:40:30, Yang Yingliang wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei•com>
added to linux-can-next
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] can: flexcan: Switch to use dev_err_probe() helper
@ 2022-09-14 13:40 Yang Yingliang
2022-09-14 13:38 ` Marc Kleine-Budde
2022-09-17 19:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-09-14 13:40 UTC (permalink / raw)
To: linux-can, netdev; +Cc: wg, mkl
dev_err() can be replace with dev_err_probe() which will check if error
code is -EPROBE_DEFER.
Signed-off-by: Yang Yingliang <yangyingliang@huawei•com>
---
drivers/net/can/flexcan/flexcan-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
index f857968efed7..ac881394e3b4 100644
--- a/drivers/net/can/flexcan/flexcan-core.c
+++ b/drivers/net/can/flexcan/flexcan-core.c
@@ -2177,8 +2177,7 @@ static int flexcan_probe(struct platform_device *pdev)
err = flexcan_setup_stop_mode(pdev);
if (err < 0) {
- if (err != -EPROBE_DEFER)
- dev_err(&pdev->dev, "setup stop mode failed\n");
+ dev_err_probe(&pdev->dev, err, "setup stop mode failed\n");
goto failed_setup_stop_mode;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] can: flexcan: Switch to use dev_err_probe() helper
2022-09-14 13:40 [PATCH -next] can: flexcan: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-14 13:38 ` Marc Kleine-Budde
@ 2022-09-17 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-17 19:20 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-can, netdev, wg, mkl
Hello:
This patch was applied to netdev/net-next.git (master)
by Marc Kleine-Budde <mkl@pengutronix•de>:
On Wed, 14 Sep 2022 21:40:30 +0800 you wrote:
> dev_err() can be replace with dev_err_probe() which will check if error
> code is -EPROBE_DEFER.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei•com>
> ---
> drivers/net/can/flexcan/flexcan-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- [-next] can: flexcan: Switch to use dev_err_probe() helper
https://git.kernel.org/netdev/net-next/c/1c679f917397
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-17 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-14 13:40 [PATCH -next] can: flexcan: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-14 13:38 ` Marc Kleine-Budde
2022-09-17 19:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox