* [PATCH net v1] mlxbf_gige: clear MDIO gateway lock after read
@ 2022-09-02 16:42 David Thompson
2022-09-19 21:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: David Thompson @ 2022-09-02 16:42 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni
Cc: netdev, cai.huoqing, brgl, limings, David Thompson, Asmaa Mnebhi
The MDIO gateway (GW) lock in BlueField-2 GIGE logic is
set after read. This patch adds logic to make sure the
lock is always cleared at the end of each MDIO transaction.
Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
Reviewed-by: Asmaa Mnebhi <asmaa@nvidia•com>
Signed-off-by: David Thompson <davthompson@nvidia•com>
---
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c
index 85155cd9405c..4aeb927c3715 100644
--- a/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c
+++ b/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c
@@ -179,6 +179,9 @@ static int mlxbf_gige_mdio_read(struct mii_bus *bus, int phy_add, int phy_reg)
/* Only return ad bits of the gw register */
ret &= MLXBF_GIGE_MDIO_GW_AD_MASK;
+ /* The MDIO lock is set on read. To release it, clear gw register */
+ writel(0, priv->mdio_io + MLXBF_GIGE_MDIO_GW_OFFSET);
+
return ret;
}
@@ -203,6 +206,9 @@ static int mlxbf_gige_mdio_write(struct mii_bus *bus, int phy_add,
temp, !(temp & MLXBF_GIGE_MDIO_GW_BUSY_MASK),
5, 1000000);
+ /* The MDIO lock is set on read. To release it, clear gw register */
+ writel(0, priv->mdio_io + MLXBF_GIGE_MDIO_GW_OFFSET);
+
return ret;
}
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net v1] mlxbf_gige: clear MDIO gateway lock after read
2022-09-02 16:42 [PATCH net v1] mlxbf_gige: clear MDIO gateway lock after read David Thompson
@ 2022-09-19 21:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-19 21:30 UTC (permalink / raw)
To: David Thompson
Cc: davem, edumazet, kuba, pabeni, netdev, cai.huoqing, brgl, limings,
asmaa
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel•org>:
On Fri, 2 Sep 2022 12:42:47 -0400 you wrote:
> The MDIO gateway (GW) lock in BlueField-2 GIGE logic is
> set after read. This patch adds logic to make sure the
> lock is always cleared at the end of each MDIO transaction.
>
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Reviewed-by: Asmaa Mnebhi <asmaa@nvidia•com>
> Signed-off-by: David Thompson <davthompson@nvidia•com>
>
> [...]
Here is the summary with links:
- [net,v1] mlxbf_gige: clear MDIO gateway lock after read
https://git.kernel.org/netdev/net/c/182447b12144
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-19 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-02 16:42 [PATCH net v1] mlxbf_gige: clear MDIO gateway lock after read David Thompson
2022-09-19 21:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox