From: patchwork-bot+netdevbpf@kernel•org
To: Davide Caratti <dcaratti@redhat•com>
Cc: edumazet@google•com, jhs@mojatatu•com, xiyou.wangcong@gmail•com,
jiri@resnulli•us, kuba@kernel•org, netdev@vger•kernel.org
Subject: Re: [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit"
Date: Sat, 22 Apr 2023 03:40:20 +0000 [thread overview]
Message-ID: <168213482026.27640.13626059018545502132.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <7b3a3c7e36d03068707a021760a194a8eb5ad41a.1682002300.git.dcaratti@redhat.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Thu, 20 Apr 2023 16:59:46 +0200 you wrote:
> if sch_fq is configured with "initial quantum" having values greater than
> INT_MAX, the first assignment of "credit" does signed integer overflow to
> a very negative value.
> In this situation, the syzkaller script provided by Cristoph triggers the
> CPU soft-lockup warning even with few sockets. It's not an infinite loop,
> but "credit" wasn't probably meant to be minus 2Gb for each new flow.
> Capping "initial quantum" to INT_MAX proved to fix the issue.
>
> [...]
Here is the summary with links:
- [net,v2] net/sched: sch_fq: fix integer overflow of "credit"
https://git.kernel.org/netdev/net/c/7041101ff6c3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-04-22 3:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 14:59 [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit" Davide Caratti
2023-04-20 16:25 ` Pedro Tammela
2023-04-20 23:24 ` Jakub Kicinski
2023-04-21 14:24 ` Pedro Tammela
2023-04-21 15:58 ` Davide Caratti
2023-04-22 3:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168213482026.27640.13626059018545502132.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=dcaratti@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox