* [PATCH 1/1] ethernet: atheros: fix return value check in atl1c_tso_csum()
@ 2023-07-20 14:42 Yuanjun Gong
2023-07-21 13:55 ` Simon Horman
2023-07-24 9:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yuanjun Gong @ 2023-07-20 14:42 UTC (permalink / raw)
To: Chris Snook, David S . Miller, Eric Dumazet, Jakub Kicinski,
netdev
Cc: Yuanjun Gong
in atl1c_tso_csum, it should check the return value of pskb_trim(),
and return an error code if an unexpected value is returned
by pskb_trim().
Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163•com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 4a288799633f..940c5d1ff9cf 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -2094,8 +2094,11 @@ static int atl1c_tso_csum(struct atl1c_adapter *adapter,
real_len = (((unsigned char *)ip_hdr(skb) - skb->data)
+ ntohs(ip_hdr(skb)->tot_len));
- if (real_len < skb->len)
- pskb_trim(skb, real_len);
+ if (real_len < skb->len) {
+ err = pskb_trim(skb, real_len);
+ if (err)
+ return err;
+ }
hdr_len = skb_tcp_all_headers(skb);
if (unlikely(skb->len == hdr_len)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] ethernet: atheros: fix return value check in atl1c_tso_csum()
2023-07-20 14:42 [PATCH 1/1] ethernet: atheros: fix return value check in atl1c_tso_csum() Yuanjun Gong
@ 2023-07-21 13:55 ` Simon Horman
2023-07-24 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-07-21 13:55 UTC (permalink / raw)
To: Yuanjun Gong
Cc: Chris Snook, David S . Miller, Eric Dumazet, Jakub Kicinski,
netdev
On Thu, Jul 20, 2023 at 10:42:08PM +0800, Yuanjun Gong wrote:
> in atl1c_tso_csum, it should check the return value of pskb_trim(),
> and return an error code if an unexpected value is returned
> by pskb_trim().
>
> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163•com>
Reviewed-by: Simon Horman <simon.horman@corigine•com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ethernet: atheros: fix return value check in atl1c_tso_csum()
2023-07-20 14:42 [PATCH 1/1] ethernet: atheros: fix return value check in atl1c_tso_csum() Yuanjun Gong
2023-07-21 13:55 ` Simon Horman
@ 2023-07-24 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-24 9:40 UTC (permalink / raw)
To: Yuanjun Gong; +Cc: chris.snook, davem, edumazet, kuba, netdev
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft•net>:
On Thu, 20 Jul 2023 22:42:08 +0800 you wrote:
> in atl1c_tso_csum, it should check the return value of pskb_trim(),
> and return an error code if an unexpected value is returned
> by pskb_trim().
>
> Signed-off-by: Yuanjun Gong <ruc_gongyuanjun@163•com>
> ---
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Here is the summary with links:
- [1/1] ethernet: atheros: fix return value check in atl1c_tso_csum()
https://git.kernel.org/netdev/net/c/8d01da0a1db2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-24 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 14:42 [PATCH 1/1] ethernet: atheros: fix return value check in atl1c_tso_csum() Yuanjun Gong
2023-07-21 13:55 ` Simon Horman
2023-07-24 9:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox