From: patchwork-bot+netdevbpf@kernel•org
To: David Rheinsberg <david@readahead•eu>
Cc: netdev@vger•kernel.org, alexander@mihalicyn•com,
brauner@kernel•org, davem@davemloft•net, sdf@google•com,
bluca@debian•org, edumazet@google•com
Subject: Re: [PATCH] net/unix: use consistent error code in SO_PEERPIDFD
Date: Tue, 08 Aug 2023 23:40:24 +0000 [thread overview]
Message-ID: <169153802432.28457.6086626478447395695.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230807081225.816199-1-david@readahead.eu>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Mon, 7 Aug 2023 10:12:25 +0200 you wrote:
> Change the new (unreleased) SO_PEERPIDFD sockopt to return ENODATA
> rather than ESRCH if a socket type does not support remote peer-PID
> queries.
>
> Currently, SO_PEERPIDFD returns ESRCH when the socket in question is
> not an AF_UNIX socket. This is quite unexpected, given that one would
> assume ESRCH means the peer process already exited and thus cannot be
> found. However, in that case the sockopt actually returns EINVAL (via
> pidfd_prepare()). This is rather inconsistent with other syscalls, which
> usually return ESRCH if a given PID refers to a non-existant process.
>
> [...]
Here is the summary with links:
- net/unix: use consistent error code in SO_PEERPIDFD
https://git.kernel.org/netdev/net/c/b6f79e826fbd
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-08 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 8:12 [PATCH] net/unix: use consistent error code in SO_PEERPIDFD David Rheinsberg
2023-08-07 8:19 ` Alexander Mikhalitsyn
2023-08-07 8:40 ` Christian Brauner
2023-08-07 9:50 ` Luca Boccassi
2023-08-08 13:00 ` Simon Horman
2023-08-08 23:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169153802432.28457.6086626478447395695.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=alexander@mihalicyn$(echo .)com \
--cc=bluca@debian$(echo .)org \
--cc=brauner@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=david@readahead$(echo .)eu \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sdf@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox