From: patchwork-bot+netdevbpf@kernel•org
To: <edward.cree@amd•com>
Cc: linux-net-drivers@amd•com, davem@davemloft•net, kuba@kernel•org,
edumazet@google•com, pabeni@redhat•com, ecree.xilinx@gmail•com,
netdev@vger•kernel.org, habetsm.xilinx@gmail•com,
andy.moreton@amd•com
Subject: Re: [PATCH net] sfc: allocate a big enough SKB for loopback selftest packet
Date: Tue, 22 Aug 2023 18:20:23 +0000 [thread overview]
Message-ID: <169272842337.23867.1886199095677767522.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230821180153.18652-1-edward.cree@amd.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Mon, 21 Aug 2023 19:01:53 +0100 you wrote:
> From: Edward Cree <ecree.xilinx@gmail•com>
>
> Cited commits passed a size to alloc_skb that was only big enough for
> the actual packet contents, but the following skb_put + memcpy writes
> the whole struct efx_loopback_payload including leading and trailing
> padding bytes (which are then stripped off with skb_pull/skb_trim).
> This could cause an skb_over_panic, although in practice we get saved
> by kmalloc_size_roundup.
> Pass the entire size we use, instead of the size of the final packet.
>
> [...]
Here is the summary with links:
- [net] sfc: allocate a big enough SKB for loopback selftest packet
https://git.kernel.org/netdev/net/c/6dc5774deefe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-22 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 18:01 [PATCH net] sfc: allocate a big enough SKB for loopback selftest packet edward.cree
2023-08-22 7:38 ` Simon Horman
2023-08-22 18:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169272842337.23867.1886199095677767522.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=andy.moreton@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox