From: patchwork-bot+netdevbpf@kernel•org
To: Rahul Rameshbabu <rrameshbabu@nvidia•com>
Cc: netdev@vger•kernel.org, gal@nvidia•com, kuba@kernel•org,
pabeni@redhat•com, edumazet@google•com,
radu-nicolae.pirea@oss•nxp.com, davem@davemloft•net,
sd@queasysnail•net
Subject: Re: [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb"
Date: Wed, 24 Jan 2024 01:30:30 +0000 [thread overview]
Message-ID: <170605983042.14933.14640605615298216416.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240118191811.50271-1-rrameshbabu@nvidia.com>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Thu, 18 Jan 2024 11:18:06 -0800 you wrote:
> This reverts commit b34ab3527b9622ca4910df24ff5beed5aa66c6b5.
>
> Using skb_ensure_writable_head_tail without a call to skb_unshare causes
> the MACsec stack to operate on the original skb rather than a copy in the
> macsec_encrypt path. This causes the buffer to be exceeded in space, and
> leads to warnings generated by skb_put operations. Opting to revert this
> change since skb_copy_expand is more efficient than
> skb_ensure_writable_head_tail followed by a call to skb_unshare.
>
> [...]
Here is the summary with links:
- [net,v2,1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb"
https://git.kernel.org/netdev/net/c/3222bc997a24
- [net,v2,2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-01-24 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 19:18 [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Rahul Rameshbabu
2024-01-18 19:18 ` [PATCH net v2 2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented Rahul Rameshbabu
2024-01-21 9:29 ` Sabrina Dubroca
2024-01-22 18:06 ` Rahul Rameshbabu
2024-01-21 9:32 ` [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Sabrina Dubroca
2024-01-23 9:19 ` Paolo Abeni
2024-01-23 16:27 ` Rahul Rameshbabu
2024-01-24 1:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170605983042.14933.14640605615298216416.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=radu-nicolae.pirea@oss$(echo .)nxp.com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox