From: Rahul Rameshbabu <rrameshbabu@nvidia•com>
To: Paolo Abeni <pabeni@redhat•com>
Cc: Sabrina Dubroca <sd@queasysnail•net>,
netdev@vger•kernel.org, Gal Pressman <gal@nvidia•com>,
Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
Radu Pirea <radu-nicolae.pirea@oss•nxp.com>,
"David S . Miller" <davem@davemloft•net>
Subject: Re: [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb"
Date: Tue, 23 Jan 2024 08:27:04 -0800 [thread overview]
Message-ID: <87r0i8m2td.fsf@nvidia.com> (raw)
In-Reply-To: <5532f8bea2241004c279bc6226a0f37df2720971.camel@redhat.com>
On Tue, 23 Jan, 2024 10:19:21 +0100 Paolo Abeni <pabeni@redhat•com> wrote:
> On Sun, 2024-01-21 at 10:32 +0100, Sabrina Dubroca wrote:
>> 2024-01-18, 11:18:06 -0800, Rahul Rameshbabu wrote:
>> > This reverts commit b34ab3527b9622ca4910df24ff5beed5aa66c6b5.
>> >
>> > Using skb_ensure_writable_head_tail without a call to skb_unshare causes
>> > the MACsec stack to operate on the original skb rather than a copy in the
>> > macsec_encrypt path. This causes the buffer to be exceeded in space, and
>> > leads to warnings generated by skb_put operations. Opting to revert this
>> > change since skb_copy_expand is more efficient than
>> > skb_ensure_writable_head_tail followed by a call to skb_unshare.
>>
>> Paolo, are you ok with this commit message? I agree it's a bit
>> confusing but I can't think of anything clearer :(
>
> Yes, I re-read the relevant code and now the fix is clearer to me,
> thanks!
I tried thinking of how to rephrase that description a couple of times
and could not come up with anything better.
>
> I understand the intention is to drop patch 2/2.
>
> Could you please confirm that? If so, I can apply 1/2 without a repost.
Yes, the intention is to drop patch 2/2. It's a "defensive" patch that
does not actually fix any issues from what I can tell.
--
Thanks,
Rahul Rameshbabu
next prev parent reply other threads:[~2024-01-23 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 19:18 [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Rahul Rameshbabu
2024-01-18 19:18 ` [PATCH net v2 2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented Rahul Rameshbabu
2024-01-21 9:29 ` Sabrina Dubroca
2024-01-22 18:06 ` Rahul Rameshbabu
2024-01-21 9:32 ` [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" Sabrina Dubroca
2024-01-23 9:19 ` Paolo Abeni
2024-01-23 16:27 ` Rahul Rameshbabu [this message]
2024-01-24 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0i8m2td.fsf@nvidia.com \
--to=rrameshbabu@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=radu-nicolae.pirea@oss$(echo .)nxp.com \
--cc=sd@queasysnail$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox