* [PATCH net-next] dsa: lan9303: consistent naming for PHY address parameter
@ 2024-07-15 12:30 Christian Eggers
2024-07-15 12:36 ` Vladimir Oltean
2024-07-15 16:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Christian Eggers @ 2024-07-15 12:30 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Juergen Beisert,
Stefan Roese, Juergen Borleis
Cc: netdev, linux-kernel, Christian Eggers
Name it 'addr' instead of 'port' or 'phy'.
Signed-off-by: Christian Eggers <ceggers@arri•de>
---
drivers/net/dsa/lan9303_mdio.c | 8 ++++----
include/linux/dsa/lan9303.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/dsa/lan9303_mdio.c b/drivers/net/dsa/lan9303_mdio.c
index 167a86f39f27..0ac4857e5ee8 100644
--- a/drivers/net/dsa/lan9303_mdio.c
+++ b/drivers/net/dsa/lan9303_mdio.c
@@ -58,19 +58,19 @@ static int lan9303_mdio_read(void *ctx, uint32_t reg, uint32_t *val)
return 0;
}
-static int lan9303_mdio_phy_write(struct lan9303 *chip, int phy, int reg,
+static int lan9303_mdio_phy_write(struct lan9303 *chip, int addr, int reg,
u16 val)
{
struct lan9303_mdio *sw_dev = dev_get_drvdata(chip->dev);
- return mdiobus_write_nested(sw_dev->device->bus, phy, reg, val);
+ return mdiobus_write_nested(sw_dev->device->bus, addr, reg, val);
}
-static int lan9303_mdio_phy_read(struct lan9303 *chip, int phy, int reg)
+static int lan9303_mdio_phy_read(struct lan9303 *chip, int addr, int reg)
{
struct lan9303_mdio *sw_dev = dev_get_drvdata(chip->dev);
- return mdiobus_read_nested(sw_dev->device->bus, phy, reg);
+ return mdiobus_read_nested(sw_dev->device->bus, addr, reg);
}
static const struct lan9303_phy_ops lan9303_mdio_phy_ops = {
diff --git a/include/linux/dsa/lan9303.h b/include/linux/dsa/lan9303.h
index b4f22112ba75..3ce7cbcc37a3 100644
--- a/include/linux/dsa/lan9303.h
+++ b/include/linux/dsa/lan9303.h
@@ -5,8 +5,8 @@ struct lan9303;
struct lan9303_phy_ops {
/* PHY 1 and 2 access*/
- int (*phy_read)(struct lan9303 *chip, int port, int regnum);
- int (*phy_write)(struct lan9303 *chip, int port,
+ int (*phy_read)(struct lan9303 *chip, int addr, int regnum);
+ int (*phy_write)(struct lan9303 *chip, int addr,
int regnum, u16 val);
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] dsa: lan9303: consistent naming for PHY address parameter
2024-07-15 12:30 [PATCH net-next] dsa: lan9303: consistent naming for PHY address parameter Christian Eggers
@ 2024-07-15 12:36 ` Vladimir Oltean
2024-07-15 16:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vladimir Oltean @ 2024-07-15 12:36 UTC (permalink / raw)
To: Christian Eggers
Cc: Andrew Lunn, Florian Fainelli, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Juergen Beisert, Stefan Roese,
Juergen Borleis, netdev, linux-kernel
Hi Christian,
On Mon, Jul 15, 2024 at 02:30:50PM +0200, Christian Eggers wrote:
> Name it 'addr' instead of 'port' or 'phy'.
>
> Signed-off-by: Christian Eggers <ceggers@arri•de>
> ---
There was a small time window in which you should have sent the patch,
after the 'net' -> 'net-next' merge, but before the 'net-next' closure.
https://lore.kernel.org/netdev/20240714204612.738afb58@kernel.org/
You missed it, and so, you now need to wait, according to Jakub, until
July 28 and resend then.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] dsa: lan9303: consistent naming for PHY address parameter
2024-07-15 12:30 [PATCH net-next] dsa: lan9303: consistent naming for PHY address parameter Christian Eggers
2024-07-15 12:36 ` Vladimir Oltean
@ 2024-07-15 16:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-07-15 16:10 UTC (permalink / raw)
To: Christian Eggers
Cc: andrew, f.fainelli, olteanv, davem, edumazet, kuba, pabeni, jbe,
sr, kernel, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel•org>:
On Mon, 15 Jul 2024 14:30:50 +0200 you wrote:
> Name it 'addr' instead of 'port' or 'phy'.
>
> Signed-off-by: Christian Eggers <ceggers@arri•de>
> ---
> drivers/net/dsa/lan9303_mdio.c | 8 ++++----
> include/linux/dsa/lan9303.h | 4 ++--
> 2 files changed, 6 insertions(+), 6 deletions(-)
Here is the summary with links:
- [net-next] dsa: lan9303: consistent naming for PHY address parameter
https://git.kernel.org/netdev/net-next/c/f96eb1172ed8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-15 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 12:30 [PATCH net-next] dsa: lan9303: consistent naming for PHY address parameter Christian Eggers
2024-07-15 12:36 ` Vladimir Oltean
2024-07-15 16:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox