* Re: [PATCH] compile error in ieee80211_ioctl.c [not found] <20060425211236.GC19116@tuxdriver.com> @ 2006-04-26 16:29 ` Alex Davis 2006-04-26 16:37 ` Jiri Benc 0 siblings, 1 reply; 6+ messages in thread From: Alex Davis @ 2006-04-26 16:29 UTC (permalink / raw) To: John W. Linville; +Cc: netdev, linux-kernel --- "John W. Linville" <linville@tuxdriver•com> wrote: > On Tue, Apr 25, 2006 at 02:04:50PM -0700, Alex Davis wrote: > > Hello: > > > > I sent this patch earlier and got no response, so I'm sending it again. > > > > > > I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git > > last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c > > into a module: > > You need to address Randy's concerns as well. > > Thanks, > > John Here is an updated patch which addresses Randy's issues. I'm currently running this with no problems: Signed-off-by: Alex Davis <alex14641@yahoo•com> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c index 42a7abe..1b14e6c 100644 --- a/net/d80211/ieee80211_ioctl.c +++ b/net/d80211/ieee80211_ioctl.c @@ -30,7 +30,7 @@ #include "aes_ccm.h" static int ieee80211_regdom = 0x10; /* FCC */ -MODULE_PARM(ieee80211_regdom, "i"); +module_param(ieee80211_regdom, int, 0666); MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK"); /* @@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE * module. */ static int ieee80211_japan_5ghz /* = 0 */; -MODULE_PARM(ieee80211_japan_5ghz, "i"); +module_param(ieee80211_japan_5ghz, int, 0666); MODULE_PARM_DESC(ieee80211_japan_5ghz, "Vendor-updated firmware for 5 GHz"); > John W. Linville > linville@tuxdriver•com > I code, therefore I am __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] compile error in ieee80211_ioctl.c 2006-04-26 16:29 ` [PATCH] compile error in ieee80211_ioctl.c Alex Davis @ 2006-04-26 16:37 ` Jiri Benc 2006-04-26 20:49 ` John W. Linville 0 siblings, 1 reply; 6+ messages in thread From: Jiri Benc @ 2006-04-26 16:37 UTC (permalink / raw) To: Alex Davis; +Cc: John W. Linville, netdev On Wed, 26 Apr 2006 09:29:46 -0700 (PDT), Alex Davis wrote: > Here is an updated patch which addresses Randy's issues. I'm currently running > this with no problems: > [...] > +module_param(ieee80211_regdom, int, 0666); > MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK"); NAK. Those parameters should not be writable yet. Please see http://marc.theaimsgroup.com/?l=linux-netdev&m=114565040832451&w=2 for the correct patch (hopefully John will pull it soon). Jiri -- Jiri Benc SUSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] compile error in ieee80211_ioctl.c 2006-04-26 16:37 ` Jiri Benc @ 2006-04-26 20:49 ` John W. Linville 2006-05-05 2:37 ` iwconfig shows Encrypt key off when using WEP Alex Davis 0 siblings, 1 reply; 6+ messages in thread From: John W. Linville @ 2006-04-26 20:49 UTC (permalink / raw) To: Jiri Benc; +Cc: Alex Davis, netdev On Wed, Apr 26, 2006 at 06:37:34PM +0200, Jiri Benc wrote: > On Wed, 26 Apr 2006 09:29:46 -0700 (PDT), Alex Davis wrote: > > Here is an updated patch which addresses Randy's issues. I'm currently running > > this with no problems: > > [...] > > +module_param(ieee80211_regdom, int, 0666); > > MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK"); > > NAK. Those parameters should not be writable yet. > > Please see > http://marc.theaimsgroup.com/?l=linux-netdev&m=114565040832451&w=2 for > the correct patch (hopefully John will pull it soon). This has now been addressed. Thanks! John -- John W. Linville linville@tuxdriver•com ^ permalink raw reply [flat|nested] 6+ messages in thread
* iwconfig shows Encrypt key off when using WEP. 2006-04-26 20:49 ` John W. Linville @ 2006-05-05 2:37 ` Alex Davis 0 siblings, 0 replies; 6+ messages in thread From: Alex Davis @ 2006-05-05 2:37 UTC (permalink / raw) To: linville, netdev I'm using the latest wireless dev git. wireless tools version 28. wpa_supplicant 0.4.8 . Here's the output of iwconfig wlan0: wlan0 IEEE 802.11g ESSID:"mysid" Mode:Managed Frequency:2.437 GHz Access Point: xx:xx..... RTS thr:off Fragment thr=2346 B Encryption key:off <--- should be 'on' Here's lspci -v: 2:03.0 Network controller: Broadcom Corporation BCM4309 802.11a/b/g (rev 03) Subsystem: Dell Truemobile 1450 MiniPCI Flags: bus master, fast devsel, latency 32, IRQ 7 Memory at fafee000 (32-bit, non-prefetchable) [size=8K] Here's the dmesg output from loading the module: 21428.599628] bcm43xx_d80211 driver [21428.609511] ACPI: PCI Interrupt 0000:02:03.0[A] -> Link [LNKB] -> GSI 7 (level, low) -> IRQ 7 [21428.615559] bcm43xx_d80211: Chip ID 0x4306, rev 0x3 [21428.615561] bcm43xx_d80211: Number of cores: 5 [21428.615566] bcm43xx_d80211: Core 0: ID 0x800, rev 0x4, vendor 0x4243, enabled [21428.615574] bcm43xx_d80211: Core 1: ID 0x812, rev 0x5, vendor 0x4243, disabled [21428.615582] bcm43xx_d80211: Core 2: ID 0x80d, rev 0x2, vendor 0x4243, enabled [21428.615590] bcm43xx_d80211: Core 3: ID 0x807, rev 0x2, vendor 0x4243, disabled [21428.615597] bcm43xx_d80211: Core 4: ID 0x804, rev 0x9, vendor 0x4243, enabled [21428.618895] bcm43xx_d80211: PHY connected [21428.618907] bcm43xx_d80211: Detected PHY: Version: 2, Type 2, Revision 2 [21428.618928] bcm43xx_d80211: Detected Radio: ID: 2205017f (Manuf: 17f Ver: 2050 Rev: 2) [21428.618943] bcm43xx_d80211: Radio turned off [21428.618970] bcm43xx_d80211: Radio turned off [21428.689486] wmaster0: Selected rate control algorithm 'simple' [21428.789510] bcm43xx_d80211: PHY connected [21428.992261] bcm43xx_d80211: Radio turned on [21429.186760] bcm43xx_d80211: Chip initialized [21429.186974] bcm43xx_d80211: DMA initialized [21429.186985] bcm43xx_d80211: 80211 cores initialized [21429.187199] bcm43xx_d80211: Keys cleared [21429.187239] wmaster0: Does not support passive scan, disabled Here's my wep.conf file: # Static WEP keys ctrl_interface=/var/run/wpa_supplicant network={ ssid="mysid" auth_alg=OPEN key_mgmt=NONE wep_key0=111111919191919191919 wep_tx_keyidx=0 } Here's the wpa_supplicant command: wpa_supplicant -D wext -c ~/wep.conf -i wlan0 Other than that, it's been working perfectly. Thanks I code, therefore I am __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] compile error in ieee80211_ioctl.c @ 2006-04-24 0:26 Alex Davis 2006-04-24 1:53 ` Randy.Dunlap 0 siblings, 1 reply; 6+ messages in thread From: Alex Davis @ 2006-04-24 0:26 UTC (permalink / raw) To: linville, netdev Hello: I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c into a module. This patch fixes it. Signed-off-by: Alex Davis <alex14641@yahoo•com> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c index 42a7abe..4949e52 100644 --- a/net/d80211/ieee80211_ioctl.c +++ b/net/d80211/ieee80211_ioctl.c @@ -30,7 +30,7 @@ #include "aes_ccm.h" static int ieee80211_regdom = 0x10; /* FCC */ -MODULE_PARM(ieee80211_regdom, "i"); +module_param(ieee80211_regdom, int, 0x10); MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK"); /* @@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE * module. */ static int ieee80211_japan_5ghz /* = 0 */; -MODULE_PARM(ieee80211_japan_5ghz, "i"); +module_param(ieee80211_japan_5ghz, int, 0); MODULE_PARM_DESC(ieee80211_japan_5ghz, "Vendor-updated firmware for 5 GHz"); I code, therefore I am __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] compile error in ieee80211_ioctl.c 2006-04-24 0:26 [PATCH] compile error in ieee80211_ioctl.c Alex Davis @ 2006-04-24 1:53 ` Randy.Dunlap 0 siblings, 0 replies; 6+ messages in thread From: Randy.Dunlap @ 2006-04-24 1:53 UTC (permalink / raw) To: Alex Davis; +Cc: linville, netdev On Sun, 23 Apr 2006 17:26:39 -0700 (PDT) Alex Davis wrote: > Hello: > > I cloned git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-dev.git > last night and got compile errors while compiling net/d80211/ieee80211_ioctl.c > into a module. This patch fixes it. > > Signed-off-by: Alex Davis <alex14641@yahoo•com> > > diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c > index 42a7abe..4949e52 100644 > --- a/net/d80211/ieee80211_ioctl.c > +++ b/net/d80211/ieee80211_ioctl.c > @@ -30,7 +30,7 @@ #include "aes_ccm.h" > > > static int ieee80211_regdom = 0x10; /* FCC */ > -MODULE_PARM(ieee80211_regdom, "i"); > +module_param(ieee80211_regdom, int, 0x10); > MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain; 64=MKK"); The last parameter of module_param() is a permission value, not an init value. The int is already initialized above. Typical permission values are 0, 0444, 0644, ... (octal, or use the available #defines). > /* > @@ -40,7 +40,7 @@ MODULE_PARM_DESC(ieee80211_regdom, "IEEE > * module. > */ > static int ieee80211_japan_5ghz /* = 0 */; > -MODULE_PARM(ieee80211_japan_5ghz, "i"); > +module_param(ieee80211_japan_5ghz, int, 0); > MODULE_PARM_DESC(ieee80211_japan_5ghz, "Vendor-updated firmware for 5 GHz"); --- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-05-05 2:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060425211236.GC19116@tuxdriver.com>
2006-04-26 16:29 ` [PATCH] compile error in ieee80211_ioctl.c Alex Davis
2006-04-26 16:37 ` Jiri Benc
2006-04-26 20:49 ` John W. Linville
2006-05-05 2:37 ` iwconfig shows Encrypt key off when using WEP Alex Davis
2006-04-24 0:26 [PATCH] compile error in ieee80211_ioctl.c Alex Davis
2006-04-24 1:53 ` Randy.Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox