From: "Edgar E. Iglesias" <edgar.iglesias@axis•com>
To: Thibaut VARENE <T-Bone@parisc-linux•org>
Cc: Stephen Hemminger <shemminger@osdl•org>,
netdev@vger•kernel.org, Jeff Garzik <jeff@garzik•org>
Subject: Re: [BUG] in skge.c on 2.6.18-rc5
Date: Thu, 31 Aug 2006 10:48:28 +0200 [thread overview]
Message-ID: <20060831084828.GD12754@edgar.underground.se.axis.com> (raw)
In-Reply-To: <7d01f9f00608301036m621149bt82b4c007a6432a6@mail.gmail.com>
On Wed, Aug 30, 2006 at 07:36:56PM +0200, Thibaut VARENE wrote:
> On 8/30/06, Stephen Hemminger <shemminger@osdl•org> wrote:
> >On Wed, 30 Aug 2006 19:21:20 +0200
> >"Thibaut VARENE" <T-Bone@parisc-linux•org> wrote:
> >
> >> Replying to myself as I've been pointed at Stephen's reply (please CC
> >> me, i'm not subscribed):
> >>
> >> I'm bringing the interface up with 'dhclient eth0', and yes it's using
> >autoneg.
> >>
> >
> >Any chance of getting a backtrace; serial port, digital camera,
> >handwritten note?
>
> If you can deal with this extremely blurry shot:
> http://www.pateam.org/archive/tmp/IMGP0825.JPG
>
> begins with "mod_timer" / "neigh_update" / "read_lock" and so on.
>
> Worst case I'll reproduce the bug again and dump a better bt, but I'd
> rather avoid as much as possible as I use that machine a lot right now
> ;P
Hi,
It may be safer to disable pollers for the entire down procedure. I think
we might also have races where xmitters are active while we are in
skge_down. Taking the txlock around netif_stop_queue probably doens't help
as a txirq can hit just after and wakeup the queue. Dont know if the
xmitters while in skge_down will cause problems though.
I have no skge hw so I am pretty much in the dark, cannot test anything,
sorry.
Best regards
--
Programmer
Edgar E. Iglesias <edgar.iglesias@axis•com> 46.46.272.1946
Subject: [PATCH] disable pollers while stopping hw, not just around rx_clean.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@axis•com>
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index ad878df..cd8c1e4 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2236,6 +2236,7 @@ static int skge_down(struct net_device *
if (netif_msg_ifdown(skge))
printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);
+ netif_poll_disable(dev);
netif_stop_queue(dev);
skge_write8(skge->hw, SK_REG(skge->port, LNK_LED_REG), LED_OFF);
@@ -2280,7 +2281,6 @@ static int skge_down(struct net_device *
skge_led(skge, LED_MODE_OFF);
- netif_poll_disable(dev);
skge_tx_clean(skge);
skge_rx_clean(skge);
prev parent reply other threads:[~2006-08-31 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 15:30 [BUG] in skge.c on 2.6.18-rc5 Thibaut VARENE
2006-08-30 16:17 ` Stephen Hemminger
2006-08-30 17:21 ` Thibaut VARENE
2006-08-30 17:29 ` Stephen Hemminger
2006-08-30 17:36 ` Thibaut VARENE
2006-08-31 8:48 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060831084828.GD12754@edgar.underground.se.axis.com \
--to=edgar.iglesias@axis$(echo .)com \
--cc=T-Bone@parisc-linux$(echo .)org \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox