From: Stephen Hemminger <shemminger@osdl•org>
To: "Thibaut VARENE" <T-Bone@parisc-linux•org>
Cc: netdev@vger•kernel.org, "Jeff Garzik" <jeff@garzik•org>
Subject: Re: [BUG] in skge.c on 2.6.18-rc5
Date: Wed, 30 Aug 2006 09:17:14 -0700 [thread overview]
Message-ID: <20060830091714.6fa70274@localhost.localdomain> (raw)
In-Reply-To: <7d01f9f00608300830j74871672o31b9ce126ee8c07d@mail.gmail.com>
On Wed, 30 Aug 2006 17:30:46 +0200
"Thibaut VARENE" <T-Bone@parisc-linux•org> wrote:
> Hi,
>
> The following commit:
>
> commit 239e44e1f05e2163ee066c07a753f9fb445979b2
> Author: Edgar E. Iglesias <edgar.iglesias@axis•com>
> Date: Mon Aug 14 23:00:24 2006 -0700
>
> [PATCH] skge: remember to run netif_poll_disable()
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@axis•com>
> Cc: Stephen Hemminger <shemminger@osdl•org>
> Cc: Jeff Garzik <jeff@garzik•org>
> Signed-off-by: Andrew Morton <akpm@osdl•org>
> Signed-off-by: Jeff Garzik <jeff@garzik•org>
>
> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> index 7de9a07..ad878df 100644
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
> @@ -2211,6 +2211,7 @@ static int skge_up(struct net_device *de
> skge_write8(hw, Q_ADDR(rxqaddr[port], Q_CSR), CSR_START |
> CSR_IRQ_CL_F); skge_led(skge, LED_MODE_ON);
>
> + netif_poll_enable(dev);
> return 0;
>
> free_rx_ring:
> @@ -2279,6 +2280,7 @@ static int skge_down(struct net_device *
>
> skge_led(skge, LED_MODE_OFF);
>
> + netif_poll_disable(dev);
> skge_tx_clean(skge);
> skge_rx_clean(skge);
>
>
> panics my 2.6.18-rc5 kernel on my em64t box apparently on first
> network activity (eg 'ping'). Reverting it gets me back to a
> functional kernel
How are you bringing the network up, are you using autonegotiation?
--
Stephen Hemminger <shemminger@osdl•org>
next prev parent reply other threads:[~2006-08-30 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 15:30 [BUG] in skge.c on 2.6.18-rc5 Thibaut VARENE
2006-08-30 16:17 ` Stephen Hemminger [this message]
2006-08-30 17:21 ` Thibaut VARENE
2006-08-30 17:29 ` Stephen Hemminger
2006-08-30 17:36 ` Thibaut VARENE
2006-08-31 8:48 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060830091714.6fa70274@localhost.localdomain \
--to=shemminger@osdl$(echo .)org \
--cc=T-Bone@parisc-linux$(echo .)org \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox