* [patch 1/7] Update smc91x driver with ARM Versatile board info
@ 2006-10-10 21:33 akpm
2006-10-14 11:02 ` Russell King
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2006-10-10 21:33 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, dsaxena, nico, rmk
From: Deepak Saxena <dsaxena@plexity•net>
We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
generic IRQ layer will complain thusly:
No IRQF_TRIGGER set_type function for IRQ 25 (<NULL>)
Signed-off-by: Deepak Saxena <dsaxena@plexity•net>
Cc: Jeff Garzik <jeff@garzik•org>
Cc: Russell King <rmk@arm•linux.org.uk>
Cc: Nicolas Pitre <nico@cam•org>
Signed-off-by: Andrew Morton <akpm@osdl•org>
---
drivers/net/smc91x.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff -puN drivers/net/smc91x.h~update-smc91x-driver-with-arm-versatile-board-info drivers/net/smc91x.h
--- a/drivers/net/smc91x.h~update-smc91x-driver-with-arm-versatile-board-info
+++ a/drivers/net/smc91x.h
@@ -398,6 +398,24 @@ static inline void LPD7_SMC_outsw (unsig
#define SMC_IRQ_FLAGS (0)
+#elif defined(CONFIG_ARCH_VERSATILE)
+
+#define SMC_CAN_USE_8BIT 1
+#define SMC_CAN_USE_16BIT 1
+#define SMC_CAN_USE_32BIT 1
+#define SMC_NOWAIT 1
+
+#define SMC_inb(a, r) readb((a) + (r))
+#define SMC_inw(a, r) readw((a) + (r))
+#define SMC_inl(a, r) readl((a) + (r))
+#define SMC_outb(v, a, r) writeb(v, (a) + (r))
+#define SMC_outw(v, a, r) writew(v, (a) + (r))
+#define SMC_outl(v, a, r) writel(v, (a) + (r))
+#define SMC_insl(a, r, p, l) readsl((a) + (r), p, l)
+#define SMC_outsl(a, r, p, l) writesl((a) + (r), p, l)
+
+#define SMC_IRQ_FLAGS (0)
+
#else
#define SMC_CAN_USE_8BIT 1
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/7] Update smc91x driver with ARM Versatile board info
2006-10-10 21:33 [patch 1/7] Update smc91x driver with ARM Versatile board info akpm
@ 2006-10-14 11:02 ` Russell King
0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2006-10-14 11:02 UTC (permalink / raw)
To: akpm; +Cc: jeff, netdev, dsaxena, nico
On Tue, Oct 10, 2006 at 02:33:22PM -0700, akpm@osdl•org wrote:
> From: Deepak Saxena <dsaxena@plexity•net>
>
> We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new
> generic IRQ layer will complain thusly:
Or a far better solution would be to arrange to pass the IRQ flags via
the platform device IRQ resource rather than continually having to add
to the ifdef mess in smc91x.h for every machine type we come across.
--
Russell King
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-14 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-10 21:33 [patch 1/7] Update smc91x driver with ARM Versatile board info akpm
2006-10-14 11:02 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox