From: Stephen Hemminger <shemminger@osdl•org>
To: James K Lewis <jklewis@us•ibm.com>
Cc: Andrew Morton <akpm@osdl•org>, Jeff Garzik <jgarzik@pobox•com>,
jim@jklewis•com, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH] spidernet: fix transmit routine.
Date: Fri, 10 Nov 2006 11:30:50 -0800 [thread overview]
Message-ID: <20061110113050.5689c226@freekitty> (raw)
In-Reply-To: <OFF9C5DB9C.8DD003F3-ON87257222.0068A615-86257222.006950CA@us.ibm.com>
On Fri, 10 Nov 2006 13:10:25 -0600
James K Lewis <jklewis@us•ibm.com> wrote:
> Stephen,
>
> I had already tried that previously, the fail still occurred. Note that
> the skb_pad (or skb_padto) never actually fails. There is just something
> about calling it that causes the hang. Note too that I believe your patch
> is incorrect, you would still have to pci_unmap_single the correct length
> (skb_pad does not actually change skb->len which just seems plain wrong to
> me).
Yeah, that was a bad choice not to set skb->len to start with. Too late
now given how it might affect other drivers.
> I checked, and none of our "mainstream" PPC ethernet drivers (e100,
> e1000, pcnet32, tg3) have this check in them. When I have time I may add
> the pad to pcnet32 (for example) to see if it fails.
The hardware for all these drivers does padding.
> Jim Lewis
> Advisory Software Engineer
> IBM Linux Technology Center
> 512-838-7754
>
>
prev parent reply other threads:[~2006-11-10 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 17:50 [PATCH] Spidernet - remove ETH_ZLEN check in earlier patch Jim Lewis
2006-11-10 17:58 ` Stephen Hemminger
2006-11-10 18:50 ` [PATCH] spidernet: fix transmit routine Stephen Hemminger
[not found] ` <OFF9C5DB9C.8DD003F3-ON87257222.0068A615-86257222.006950CA@us.ibm.com>
2006-11-10 19:30 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110113050.5689c226@freekitty \
--to=shemminger@osdl$(echo .)org \
--cc=akpm@osdl$(echo .)org \
--cc=jgarzik@pobox$(echo .)com \
--cc=jim@jklewis$(echo .)com \
--cc=jklewis@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox