* Re: [linux-usb-devel] drivers/usb/gadget/ether.c: NULL dereference
[not found] ` <200611112310.18903.david-b@pacbell.net>
@ 2006-11-12 12:23 ` Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-11-12 12:23 UTC (permalink / raw)
To: David Brownell; +Cc: linux-usb-devel, greg, linux-kernel, davem, netdev
On Sat, Nov 11, 2006 at 11:10:17PM -0800, David Brownell wrote:
>
> >
> > void dev_kfree_skb_any(struct sk_buff *skb)
> > {
> > if (in_irq() || irqs_disabled())
> > dev_kfree_skb_irq(skb);
> > else
> > dev_kfree_skb(skb);
> > }
> >
> >
> > And the first thing dev_kfree_skb_irq() does is to dereference skb...
>
> Yet dev_kfree_skb() --> kfree_skb() starts with the standard idiom
>
> if (unlikely(!skb))
> return
>
> Seems to me that the finger of blame is more appropriately pointed
> at either dev_kfree_skb_any() or dev_kfree_skb_irq() ...
>...
Adding the net maintainers to the Cc:
Is there any reason why dev_kfree_skb_irq() has no NULL check for "skb"?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] only message in thread