From: Jarek Poplawski <jarkao2@o2•pl>
To: David Miller <davem@davemloft•net>
Cc: akpm@linux-foundation•org, jeff@garzik•org,
netdev@vger•kernel.org, jura@netams•com, paulus@samba•org
Subject: Re: [patch 04/13] ppp_generic: fix lockdep warning
Date: Mon, 14 May 2007 12:09:07 +0200 [thread overview]
Message-ID: <20070514100907.GA2780@ff.dom.local> (raw)
In-Reply-To: <20070514.021831.68041288.davem@davemloft.net>
On Mon, May 14, 2007 at 02:18:31AM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@o2•pl>
> Date: Mon, 14 May 2007 09:28:45 +0200
>
> > Yes, this is very good idea, and I wonder, why you didn't try
> > this yourself (after my "ignore").
>
> Because you are a skilled programmer and you might find some
> flaw in my suggestion :-)
>
Yes, here are some flaws:
if (Dave_M_was_ignored)
goto not_skilled_programmer;
if (Jarek_P_finds_some_flow)
goto message_sent;
else
goto message_sent; /* probably the same */
Cheers,
Jarek P.
next prev parent reply other threads:[~2007-05-14 10:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 5:52 [patch 04/13] ppp_generic: fix lockdep warning akpm
2007-05-11 20:57 ` Jeff Garzik
2007-05-11 21:03 ` David Miller
2007-05-11 21:12 ` Andrew Morton
2007-05-14 6:07 ` Jarek Poplawski
2007-05-14 6:39 ` David Miller
2007-05-14 7:28 ` Jarek Poplawski
2007-05-14 8:08 ` Jarek Poplawski
2007-05-14 12:51 ` Jarek Poplawski
2007-05-14 9:18 ` David Miller
2007-05-14 10:09 ` Jarek Poplawski [this message]
2007-05-15 5:31 ` [PATCH] netdev: lockdep classes in register_netdevice " Jarek Poplawski
2007-05-15 8:49 ` Yuriy N. Shkandybin
2007-05-15 10:05 ` Jarek Poplawski
2007-05-16 5:49 ` Jarek Poplawski
2007-05-15 8:50 ` Yuriy N. Shkandybin
2007-05-16 5:40 ` [PATCH (take 2)] " Jarek Poplawski
2007-05-16 5:47 ` David Miller
2007-05-16 6:17 ` Jarek Poplawski
2007-05-16 6:17 ` David Miller
2007-05-16 7:18 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514100907.GA2780@ff.dom.local \
--to=jarkao2@o2$(echo .)pl \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jeff@garzik$(echo .)org \
--cc=jura@netams$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox