From: Stephen Hemminger <shemminger@linux-foundation•org>
To: Patrick McHardy <kaber@trash•net>, Jeff Garzik <jgarzik@pobox•com>
Cc: Linux Netdev List <netdev@vger•kernel.org>,
Ben Greear <greearb@candelatech•com>
Subject: Re: [SKY2]: Fix VLAN unregistration
Date: Tue, 29 May 2007 10:16:28 -0700 [thread overview]
Message-ID: <20070529101628.7538f770@freepuppy> (raw)
In-Reply-To: <4659D174.70301@trash.net>
On Sun, 27 May 2007 20:44:04 +0200
Patrick McHardy <kaber@trash•net> wrote:
> Fix sky2 disabling VLAN completely when the first vid is unregistered.
>
> For some reason the VLAN code insists on the driver providing a
> vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not
> NETIF_F_HW_VLAN_FILTER is set, so this patch keeps an empty
> function. This seems to be a bug though, vlan_rx_add_vid is only
> required with NETIF_F_HW_VLAN_FILTER. Ben?
>
I put it in the next sky2 patch set. Still waiting for Jeff
to take the last one.
--
Stephen Hemminger <shemminger@linux-foundation•org>
next prev parent reply other threads:[~2007-05-29 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 18:44 [SKY2]: Fix VLAN unregistration Patrick McHardy
2007-05-28 21:42 ` Ben Greear
2007-05-29 10:57 ` Patrick McHardy
2007-05-29 17:16 ` Stephen Hemminger [this message]
2007-05-31 17:19 ` [PATCH]: sky2: " Stephen Hemminger
2007-05-31 17:37 ` Patrick McHardy
2007-05-31 18:21 ` Stephen Hemminger
2007-06-01 15:16 ` Patrick McHardy
2007-06-01 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529101628.7538f770@freepuppy \
--to=shemminger@linux-foundation$(echo .)org \
--cc=greearb@candelatech$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox