From: Patrick McHardy <kaber@trash•net>
To: Ben Greear <greearb@candelatech•com>
Cc: Stephen Hemminger <shemminger@osdl•org>,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [SKY2]: Fix VLAN unregistration
Date: Tue, 29 May 2007 12:57:31 +0200 [thread overview]
Message-ID: <465C071B.5080109@trash.net> (raw)
In-Reply-To: <465B4CCC.7020002@candelatech.com>
Ben Greear wrote:
> Patrick McHardy wrote:
>
>> Fix sky2 disabling VLAN completely when the first vid is unregistered.
>>
>> For some reason the VLAN code insists on the driver providing a
>> vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not
>> NETIF_F_HW_VLAN_FILTER is set, so this patch keeps an empty
>> function. This seems to be a bug though, vlan_rx_add_vid is only
>> required with NETIF_F_HW_VLAN_FILTER. Ben?
>>
>
> I believe DaveM did most of the vlan hw-accel work. It would be easy
> enough to check
> for a null function before calling the vlan_rx_kill_vid function and
> relax the checks
> based on the flags, but there may be valid reasons to keep this as is.
Most drivers are using vlan_rx_kill_vid to remove a vid from the
group under their local local lock, which seems unnecessary since
the VLAN code calls synchronize_net before freeing it and also
does the removal itself. A few others have empty functions and
8139cp seems to have the same bug as sky2. In all cases it doesn't
seem to be needed for drivers without NETIF_F_HW_VLAN_FILTER.
next prev parent reply other threads:[~2007-05-29 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 18:44 [SKY2]: Fix VLAN unregistration Patrick McHardy
2007-05-28 21:42 ` Ben Greear
2007-05-29 10:57 ` Patrick McHardy [this message]
2007-05-29 17:16 ` Stephen Hemminger
2007-05-31 17:19 ` [PATCH]: sky2: " Stephen Hemminger
2007-05-31 17:37 ` Patrick McHardy
2007-05-31 18:21 ` Stephen Hemminger
2007-06-01 15:16 ` Patrick McHardy
2007-06-01 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465C071B.5080109@trash.net \
--to=kaber@trash$(echo .)net \
--cc=greearb@candelatech$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox