From: "Denis V. Lunev" <den@openvz•org>
To: netdev@vger•kernel.org, davem@davemloft•net, val@nmt•edu
Cc: tulip-users@lists•sourceforge.net, devel@openvz•org
Subject: [PATCH] possible deadlock in tulip driver
Date: Tue, 24 Jul 2007 11:49:08 +0400 [thread overview]
Message-ID: <20070724074908.GA15258@iris.sw.ru> (raw)
Calling flush_scheduled_work() may deadlock if called under rtnl_lock
(from dev->stop) as linkwatch_event() may be on the workqueue and it will try
to get the rtnl_lock
Signed-off-by: Denis V. Lunev <den@openvz•org>
---
tulip_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- ./drivers/net/tulip/tulip_core.c.tulip 2007-07-16 12:54:29.000000000 +0400
+++ ./drivers/net/tulip/tulip_core.c 2007-07-23 19:06:24.000000000 +0400
@@ -726,8 +726,6 @@ static void tulip_down (struct net_devic
void __iomem *ioaddr = tp->base_addr;
unsigned long flags;
- flush_scheduled_work();
-
del_timer_sync (&tp->timer);
#ifdef CONFIG_TULIP_NAPI
del_timer_sync (&tp->oom_timer);
@@ -1788,6 +1786,8 @@ static void __devexit tulip_remove_one (
if (!dev)
return;
+ flush_scheduled_work();
+
tp = netdev_priv(dev);
unregister_netdev(dev);
pci_free_consistent (pdev,
next reply other threads:[~2007-07-24 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 7:49 Denis V. Lunev [this message]
2007-07-30 19:12 ` [PATCH] possible deadlock in tulip driver Valerie Henson
2007-07-31 6:52 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724074908.GA15258@iris.sw.ru \
--to=den@openvz$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tulip-users@lists$(echo .)sourceforge.net \
--cc=val@nmt$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox