From: "Denis V. Lunev" <den@sw•ru>
To: Valerie Henson <val@nmt•edu>
Cc: "Denis V. Lunev" <den@openvz•org>,
netdev@vger•kernel.org, davem@davemloft•net,
tulip-users@lists•sourceforge.net, devel@openvz•org
Subject: Re: [PATCH] possible deadlock in tulip driver
Date: Tue, 31 Jul 2007 10:52:34 +0400 [thread overview]
Message-ID: <46AEDC32.80709@sw.ru> (raw)
In-Reply-To: <20070730191232.GC16182@rainbow>
Manual code check. The similar fixes are present in almost all drivers,
f.e. tg3 one. I have an unrelated deadlock with rtnl.
Regards,
Den
Valerie Henson wrote:
> (No longer maintainer, btw.)
>
> What situation have you tested this under? Thanks,
>
> -VAL
>
> On Tue, Jul 24, 2007 at 11:49:08AM +0400, Denis V. Lunev wrote:
>> Calling flush_scheduled_work() may deadlock if called under rtnl_lock
>> (from dev->stop) as linkwatch_event() may be on the workqueue and it will try
>> to get the rtnl_lock
>>
>> Signed-off-by: Denis V. Lunev <den@openvz•org>
>> ---
>>
>> tulip_core.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- ./drivers/net/tulip/tulip_core.c.tulip 2007-07-16 12:54:29.000000000 +0400
>> +++ ./drivers/net/tulip/tulip_core.c 2007-07-23 19:06:24.000000000 +0400
>> @@ -726,8 +726,6 @@ static void tulip_down (struct net_devic
>> void __iomem *ioaddr = tp->base_addr;
>> unsigned long flags;
>>
>> - flush_scheduled_work();
>> -
>> del_timer_sync (&tp->timer);
>> #ifdef CONFIG_TULIP_NAPI
>> del_timer_sync (&tp->oom_timer);
>> @@ -1788,6 +1786,8 @@ static void __devexit tulip_remove_one (
>> if (!dev)
>> return;
>>
>> + flush_scheduled_work();
>> +
>> tp = netdev_priv(dev);
>> unregister_netdev(dev);
>> pci_free_consistent (pdev,
>> -
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger•kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2007-07-31 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 7:49 [PATCH] possible deadlock in tulip driver Denis V. Lunev
2007-07-30 19:12 ` Valerie Henson
2007-07-31 6:52 ` Denis V. Lunev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AEDC32.80709@sw.ru \
--to=den@sw$(echo .)ru \
--cc=davem@davemloft$(echo .)net \
--cc=den@openvz$(echo .)org \
--cc=devel@openvz$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tulip-users@lists$(echo .)sourceforge.net \
--cc=val@nmt$(echo .)edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox