From: Bill Fink <billfink@mindspring•com>
To: Hideo AOKI <haoki@redhat•com>
Cc: David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>,
Satoshi Oshima <satoshi.oshima.fk@hitachi•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Andi Kleen <andi@firstfloor•org>,
Stephen Hemminger <shemminger@linux-foundation•org>,
Evgeniy Polyakov <johnpol@2ka•mipt.ru>,
yoshfuji@linux-ipv6•org,
Yumiko Sugita <yumiko.sugita.yf@hitachi•com>
Subject: Re: [PATCH 5/5] introduce udp_rmem and udp_wmem
Date: Tue, 30 Oct 2007 00:52:48 -0400 [thread overview]
Message-ID: <20071030005248.b0e6e9d2.billfink@mindspring.com> (raw)
In-Reply-To: <47264F5F.6040905@redhat.com>
On Mon, 29 Oct 2007, Hideo AOKI wrote:
> This patch added /proc/sys/net/udp_rmem and /proc/sys/net/udp_rmem.
> Each UDP packet is drooped when the number of pages for socket buffer
> is beyond the limit and the socket already consumes minimum buffer.
I think you meant /proc/sys/net/ipv4/udp_{r,w}mem above.
Patch not in-lined making replying more difficult.
Cutting and pasting:
> diff -pruN linux-2.6.24-rc1-mem003-ipv4-dev-p4/Documentation/networking/ip-sysctl.txt linux-2.6.24-rc1-mem003-ipv4-dev-p5/Documentation/networking/ip-sysctl.txt
> --- linux-2.6.24-rc1-mem003-ipv4-dev-p4/Documentation/networking/ip-sysctl.txt 2007-10-26 20:35:52.000000000 -0400
> +++ linux-2.6.24-rc1-mem003-ipv4-dev-p5/Documentation/networking/ip-sysctl.txt 2007-10-29 09:44:05.000000000 -0400
> @@ -452,6 +452,18 @@ udp_mem - INTEGER
> Number of pages allowed for queueing by all UDP sockets.
> Default is calculated at boot time from amount of available memory.
>
> +udp_rmem - INTEGER
> + Minimal size of receive buffer used by UDP sockets. Each UDP socket
> + is able to use the size for receiving data, even if total pages of UDP
> + sockets exceed udp_mem. The unit is byte.
> + Default: 4096
> +
> +udp_wmem - INTEGER
> + Minimal size of send buffer used by UDP sockets. Each UDP socket is
> + able to use the size for sending data, even if total pages of UDP
> + sockets exceed udp_mem. The unit is byte.
> + Default: 4096
> +
> CIPSOv4 Variables:
>
> cipso_cache_enable - BOOLEAN
I think either the above should be renamed to udp_{r,w}mem_min, or
they should be changed to a 3-tuple like tcp_{r,w}mem, and the code
refactored accordingly (but then what to do about
/proc/sys/net/core/{r,w}mem_max).
-Bill
next prev parent reply other threads:[~2007-10-30 4:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 21:18 [PATCH 0/5] UDP memory accounting and limitation (take 6) Hideo AOKI
2007-10-29 21:22 ` [PATCH 1/5] fix send buffer check Hideo AOKI
2007-11-09 12:24 ` Herbert Xu
2007-11-14 3:25 ` Hideo AOKI
2007-10-29 21:23 ` [PATCH 2/5] accounting unit and variable Hideo AOKI
2007-11-09 12:34 ` Herbert Xu
2007-11-14 3:27 ` Hideo AOKI
2007-11-14 3:45 ` Herbert Xu
2007-11-14 3:55 ` David Miller
2007-11-14 15:32 ` Hideo AOKI
2007-11-14 23:30 ` Hideo AOKI
2007-11-15 1:09 ` Herbert Xu
2007-11-15 21:37 ` Hideo AOKI
2007-10-29 21:23 ` [PATCH 3/5] memory accounting Hideo AOKI
2007-11-09 13:07 ` Herbert Xu
2007-10-29 21:23 ` [PATCH 4/5] memory limitation by using udp_mem Hideo AOKI
2007-10-29 21:23 ` [PATCH 5/5] introduce udp_rmem and udp_wmem Hideo AOKI
2007-10-30 4:52 ` Bill Fink [this message]
2007-11-02 15:42 ` Hideo AOKI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030005248.b0e6e9d2.billfink@mindspring.com \
--to=billfink@mindspring$(echo .)com \
--cc=andi@firstfloor$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=haoki@redhat$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=johnpol@2ka$(echo .)mipt.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=satoshi.oshima.fk@hitachi$(echo .)com \
--cc=shemminger@linux-foundation$(echo .)org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=yumiko.sugita.yf@hitachi$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox