From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Florian Fainelli <florian.fainelli@telecomint•eu>
Cc: Jeff Garzik <jgarzik@pobox•com>, netdev@vger•kernel.org
Subject: Re: [PATCH] [NET] uli526x: add support for netpoll
Date: Fri, 16 May 2008 15:13:49 +0400 [thread overview]
Message-ID: <20080516111349.GA27587@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <200805152251.24137.florian.fainelli@telecomint.eu>
On Thu, May 15, 2008 at 10:51:23PM +0200, Florian Fainelli wrote:
> Hello Anton,
>
> Le Thursday 15 May 2008 17:12:55 Anton Vorontsov, vous avez écrit :
> > +#ifdef CONFIG_NET_POLL_CONTROLLER
> > +static void uli526x_poll(struct net_device *dev)
> > +{
> > + /* ISR grabs the irqsave lock, so this should be safe */
> > + uli526x_interrupt(dev->irq, dev);
> > +}
> > +#endif
>
> You do not need to wrap this function into the ifdef, since setting the poll
> callback is between ifdef. Otherwise patch looks good.
Nope, I need this #ifdef, otherwise gcc will warn about unused function
if netpoll is not selected.
Of course, I could do __maybe_unused, but #ifdef is what most (all?)
drivers are doing.
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-05-16 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 15:12 [PATCH] [NET] uli526x: add support for netpoll Anton Vorontsov
2008-05-15 20:51 ` Florian Fainelli
2008-05-16 11:13 ` Anton Vorontsov [this message]
2008-05-16 19:04 ` [PATCH v2] " Anton Vorontsov
2008-05-22 10:21 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516111349.GA27587@polina.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=florian.fainelli@telecomint$(echo .)eu \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox