From: Scott Wood <scottwood@freescale•com>
To: Laurent Pinchart <laurentp@cse-semaphore•com>
Cc: linuxppc-dev@ozlabs•org, jgarzik@pobox•com,
vbordug@ru•mvista.com, netdev@vger•kernel.org
Subject: Re: [PATCH 2/2] fs_enet: MDIO on GPIO support
Date: Mon, 16 Jun 2008 11:34:00 -0500 [thread overview]
Message-ID: <20080616163400.GA13996@loki.buserror.net> (raw)
In-Reply-To: <200806161057.03158.laurentp@cse-semaphore.com>
On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote:
> On Monday 26 May 2008 11:53, Laurent Pinchart wrote:
> > Port the fs_enet driver to support the MDIO on GPIO driver for PHY access
> > in addition to the mii-bitbang driver.
>
> Now that 1/2 has been applied by Jeff, could this one make it to
> powerpc-next ?
This patch should probably go through Jeff as well...
Acked-by: Scott Wood <scottwood@freescale•com>
> > - data = of_get_property(phynode, "reg", &len);
> > - if (!data || len != 4)
> > - goto out_put_mdio;
> > + bus_id = of_get_gpio(mdionode, 0);
> > + if (bus_id < 0) {
> > + struct resource res;
> > + ret = of_address_to_resource(mdionode, 0, &res);
> > + if (ret)
> > + goto out_put_mdio;
> > + bus_id = res.start;
> > + }
> >
> > - snprintf(fpi->bus_id, 16, "%x:%02x", res.start, *data);
> > + snprintf(fpi->bus_id, 16, "%x:%02x", bus_id, *data);
It'd be nice if this sort of thing could be moved to phylib, so the latter
could simply be passed a device node (in addition to current mechanisms for
the benefit of unfortunate device-tree-less architectures).
-Scott
next prev parent reply other threads:[~2008-06-16 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 9:52 [PATCH 0/2] MDIO on GPIO support for the fs_enet driver Laurent Pinchart
2008-05-26 9:53 ` [PATCH 1/2] net: OpenFirmware GPIO based MDIO bitbang driver Laurent Pinchart
2008-05-31 2:20 ` Jeff Garzik
2008-05-26 9:53 ` [PATCH 2/2] fs_enet: MDIO on GPIO support Laurent Pinchart
2008-06-16 8:57 ` Laurent Pinchart
2008-06-16 16:34 ` Scott Wood [this message]
2008-06-18 14:48 ` Laurent Pinchart
2008-06-18 15:00 ` Jeff Garzik
2008-06-18 15:16 ` Laurent Pinchart
2008-06-26 11:21 ` Laurent Pinchart
2008-06-26 13:55 ` Vitaly Bordug
2008-07-18 9:26 ` Laurent Pinchart
2008-07-18 13:40 ` Kumar Gala
2008-07-18 17:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616163400.GA13996@loki.buserror.net \
--to=scottwood@freescale$(echo .)com \
--cc=jgarzik@pobox$(echo .)com \
--cc=laurentp@cse-semaphore$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vbordug@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox