From: Jeff Garzik <jgarzik@pobox•com>
To: Laurent Pinchart <laurentp@cse-semaphore•com>
Cc: Scott Wood <scottwood@freescale•com>,
linuxppc-dev@ozlabs•org, netdev@vger•kernel.org,
vbordug@ru•mvista.com, pantelis.antoniou@gmail•com
Subject: Re: [PATCH 2/2] fs_enet: MDIO on GPIO support
Date: Wed, 18 Jun 2008 11:00:50 -0400 [thread overview]
Message-ID: <48592322.3090201@pobox.com> (raw)
In-Reply-To: <200806181648.40874.laurentp@cse-semaphore.com>
Laurent Pinchart wrote:
> Hi Scott,
>
> On Monday 16 June 2008 18:34, Scott Wood wrote:
>> On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote:
>>> On Monday 26 May 2008 11:53, Laurent Pinchart wrote:
>>>> Port the fs_enet driver to support the MDIO on GPIO driver for PHY
>>>> access in addition to the mii-bitbang driver.
>>> Now that 1/2 has been applied by Jeff, could this one make it to
>>> powerpc-next ?
>> This patch should probably go through Jeff as well...
>
> Jeff, what's your opinion on this ?
>
>> Acked-by: Scott Wood <scottwood@freescale•com>
>>
>>>> - data = of_get_property(phynode, "reg", &len);
>>>> - if (!data || len != 4)
>>>> - goto out_put_mdio;
>>>> + bus_id = of_get_gpio(mdionode, 0);
>>>> + if (bus_id < 0) {
>>>> + struct resource res;
>>>> + ret = of_address_to_resource(mdionode, 0, &res);
>>>> + if (ret)
>>>> + goto out_put_mdio;
>>>> + bus_id = res.start;
>>>> + }
>>>>
>>>> - snprintf(fpi->bus_id, 16, "%x:%02x", res.start, *data);
>>>> + snprintf(fpi->bus_id, 16, "%x:%02x", bus_id, *data);
What are the patch dependencies, if any?
My general rule is, anytime I see 80%+ of the patch dealing with
arch-specific API functions (such as OF resource stuff), I tend to
prefer that goes via an arch tree.
If it's a networking change, of course I'd prefer it came in my direction.
Jeff
next prev parent reply other threads:[~2008-06-18 15:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 9:52 [PATCH 0/2] MDIO on GPIO support for the fs_enet driver Laurent Pinchart
2008-05-26 9:53 ` [PATCH 1/2] net: OpenFirmware GPIO based MDIO bitbang driver Laurent Pinchart
2008-05-31 2:20 ` Jeff Garzik
2008-05-26 9:53 ` [PATCH 2/2] fs_enet: MDIO on GPIO support Laurent Pinchart
2008-06-16 8:57 ` Laurent Pinchart
2008-06-16 16:34 ` Scott Wood
2008-06-18 14:48 ` Laurent Pinchart
2008-06-18 15:00 ` Jeff Garzik [this message]
2008-06-18 15:16 ` Laurent Pinchart
2008-06-26 11:21 ` Laurent Pinchart
2008-06-26 13:55 ` Vitaly Bordug
2008-07-18 9:26 ` Laurent Pinchart
2008-07-18 13:40 ` Kumar Gala
2008-07-18 17:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48592322.3090201@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=laurentp@cse-semaphore$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pantelis.antoniou@gmail$(echo .)com \
--cc=scottwood@freescale$(echo .)com \
--cc=vbordug@ru$(echo .)mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox