public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Ingo Oeser <netdev@axxeo•de>
To: Wang Chen <wangchen@cn•fujitsu.com>
Cc: "David S. Miller" <davem@davemloft•net>, NETDEV <netdev@vger•kernel.org>
Subject: Re: [PATCH 1/2] ipmr: delete redundant variable
Date: Wed, 23 Jul 2008 10:03:05 +0200	[thread overview]
Message-ID: <200807231003.05848.netdev@axxeo.de> (raw)
In-Reply-To: <48868D54.6050701@cn.fujitsu.com>

Hi Wang Chen,

Wang Chen schrieb:
> *v can be removed as this patch showing.

You are right, but did you check the resulting asm?
 
> Signed-off-by: Wang Chen <wangchen@cn•fujitsu.com>
> ---
> diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
> index c519b8d..6e715c7 100644
> --- a/net/ipv4/ipmr.c
> +++ b/net/ipv4/ipmr.c
> @@ -1129,9 +1128,9 @@ static int ipmr_device_event(struct notifier_block *this, unsigned long event, v
>  
>  	if (event != NETDEV_UNREGISTER)
>  		return NOTIFY_DONE;
> -	v=&vif_table[0];
> -	for (ct=0;ct<maxvif;ct++,v++) {
> -		if (v->dev==dev)

This is ptr += sizeof(vif_table[0])

> +
> +	for (ct = 0; ct < maxvif; ct++) {
> +		if (vif_table[ct].dev == dev)

This is ptr + ct * sizeof(vif_table[0])

On architectures, where the second address variant is
not supported, it spills a register with the multiply/shift.

But the second variant could be easily auto vectorized, 
if we had no if.

So just check the asm on a CISC and a RISC architecture 
with a cross compile, before you transform these patterns.

Maybe GCC even transform one into the other these days :-)


Best Regards

Ingo Oeser

next prev parent reply	other threads:[~2008-07-23  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23  1:45 [PATCH 1/2] ipmr: delete redundant variable Wang Chen
2008-07-23  8:03 ` Ingo Oeser [this message]
2008-07-23  9:35   ` Wang Chen
2008-07-23 12:05     ` Ingo Oeser
2008-07-23 15:16       ` Wang Chen
2008-07-24  7:37       ` Wang Chen
2008-07-25 17:36         ` Ingo Oeser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807231003.05848.netdev@axxeo.de \
    --to=netdev@axxeo$(echo .)de \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=wangchen@cn$(echo .)fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox