public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ingo Oeser <netdev@axxeo•de>
To: Wang Chen <wangchen@cn•fujitsu.com>
Cc: "David S. Miller" <davem@davemloft•net>, NETDEV <netdev@vger•kernel.org>
Subject: Re: [PATCH 1/2] ipmr: delete redundant variable
Date: Fri, 25 Jul 2008 19:36:42 +0200	[thread overview]
Message-ID: <200807251936.42504.netdev@axxeo.de> (raw)
In-Reply-To: <48883131.9070805@cn.fujitsu.com>

Hi Wang Chen,

Wang Chen schrieb:
> Ingo Oeser said the following on 2008-7-23 20:05:
> > But please check the generated assembly yourself on a CISC and RISC
> > machine to get an idea of the effects. It will be a nice learning 
> > experience I enjoyed myself already.
> > 
> 
> I did the experiment.
[..]
> In loop area, they are both ptr+sizeof(struct).
> 
> Now, we can get a conclusion that current compiler can do optimize the index accessing.
> :)
> 
> Ingo, if you have any different opinion, it will be appreciated that you can share. :)

Great! Compilers improved a lot here :-)

Many thanks for doing this experiment. 

Now you and others can anyone who is is questioning
this fact to your experiment and take it as a reference for similiar changes.

That is a great help for the community, I think!


Best Regards

Ingo Oeser

      reply	other threads:[~2008-07-25 17:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23  1:45 [PATCH 1/2] ipmr: delete redundant variable Wang Chen
2008-07-23  8:03 ` Ingo Oeser
2008-07-23  9:35   ` Wang Chen
2008-07-23 12:05     ` Ingo Oeser
2008-07-23 15:16       ` Wang Chen
2008-07-24  7:37       ` Wang Chen
2008-07-25 17:36         ` Ingo Oeser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807251936.42504.netdev@axxeo.de \
    --to=netdev@axxeo$(echo .)de \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=wangchen@cn$(echo .)fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox