From: Andrew Morton <akpm@linux-foundation•org>
To: Francois Romieu <romieu@fr•zoreil.com>
Cc: jgarzik@pobox•com, netdev@vger•kernel.org,
"Séguier Régis" <rseguier@e-teleport•net>,
HaraldWelte@viatech•com, JoeyZhuo@via•com.tw, AJJiang@via•com.tw,
BruceChang@via•com.tw, WaltonLi@via•com.tw
Subject: Re: [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets
Date: Fri, 7 Nov 2008 14:51:52 -0800 [thread overview]
Message-ID: <20081107145152.f3f264fb.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081107223617.GA23082@electric-eye.fr.zoreil.com>
On Fri, 7 Nov 2008 23:36:17 +0100 Francois Romieu <romieu@fr•zoreil.com> wrote:
> Signed-off-by: Joey Zhuo <joeyzhuo@via•com.tw>
> Acked-off-by: Francois Romieu <romieu@fr•zoreil.com>
ooh, we need a Hacked-off-by too :)
I guess you meant Acked-by:, but as you were on the delivery path for
this patch, a Signed-off-by: is more appropriate.
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -2296,7 +2296,7 @@ static void velocity_set_multi(struct net_device *dev)
> }
>
> mac_set_cam_mask(regs, vptr->mCAMmask);
> - rx_mode = (RCR_AM | RCR_AB);
> + rx_mode = RCR_AM | RCR_AB | RCR_AP;
> }
> if (dev->mtu > 1500)
> rx_mode |= RCR_AL;
prev parent reply other threads:[~2008-11-07 22:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 22:36 [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets Francois Romieu
2008-11-07 22:49 ` Andrew Morton
2008-11-07 23:03 ` Francois Romieu
2008-11-07 22:51 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107145152.f3f264fb.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=AJJiang@via$(echo .)com.tw \
--cc=BruceChang@via$(echo .)com.tw \
--cc=HaraldWelte@viatech$(echo .)com \
--cc=JoeyZhuo@via$(echo .)com.tw \
--cc=WaltonLi@via$(echo .)com.tw \
--cc=jgarzik@pobox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=romieu@fr$(echo .)zoreil.com \
--cc=rseguier@e-teleport$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox