* [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets
@ 2008-11-07 22:36 Francois Romieu
2008-11-07 22:49 ` Andrew Morton
2008-11-07 22:51 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Francois Romieu @ 2008-11-07 22:36 UTC (permalink / raw)
To: jgarzik
Cc: netdev, =?unknown-8bit?B?U8OpZ3VpZXIgUsOpZ2lz?=, Andrew Morton,
HaraldWelte, JoeyZhuo, AJJiang, BruceChang, WaltonLi
Signed-off-by: Joey Zhuo <joeyzhuo@via•com.tw>
Acked-off-by: Francois Romieu <romieu@fr•zoreil.com>
---
drivers/net/via-velocity.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 3590ea5..11cb3e5 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -2296,7 +2296,7 @@ static void velocity_set_multi(struct net_device *dev)
}
mac_set_cam_mask(regs, vptr->mCAMmask);
- rx_mode = (RCR_AM | RCR_AB);
+ rx_mode = RCR_AM | RCR_AB | RCR_AP;
}
if (dev->mtu > 1500)
rx_mode |= RCR_AL;
--
1.5.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets
2008-11-07 22:36 [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets Francois Romieu
@ 2008-11-07 22:49 ` Andrew Morton
2008-11-07 23:03 ` Francois Romieu
2008-11-07 22:51 ` Andrew Morton
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-11-07 22:49 UTC (permalink / raw)
To: Francois Romieu
Cc: jgarzik, netdev, Séguier Régis, HaraldWelte, JoeyZhuo,
AJJiang, BruceChang, WaltonLi
On Fri, 7 Nov 2008 23:36:17 +0100 Francois Romieu <romieu@fr•zoreil.com> wrote:
> Signed-off-by: Joey Zhuo <joeyzhuo@via•com.tw>
> Acked-off-by: Francois Romieu <romieu@fr•zoreil.com>
> ---
> drivers/net/via-velocity.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
> index 3590ea5..11cb3e5 100644
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -2296,7 +2296,7 @@ static void velocity_set_multi(struct net_device *dev)
> }
>
> mac_set_cam_mask(regs, vptr->mCAMmask);
> - rx_mode = (RCR_AM | RCR_AB);
> + rx_mode = RCR_AM | RCR_AB | RCR_AP;
> }
> if (dev->mtu > 1500)
> rx_mode |= RCR_AL;
Is this a bugfix, a regression fix or a feature?
I assume that it was authored by Joey? The way to communicate that is
to put his From: line at the top of the changelog. As it stands, this
patch appears to have been authored by yourself.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets
2008-11-07 22:49 ` Andrew Morton
@ 2008-11-07 23:03 ` Francois Romieu
0 siblings, 0 replies; 4+ messages in thread
From: Francois Romieu @ 2008-11-07 23:03 UTC (permalink / raw)
To: Andrew Morton
Cc: jgarzik, netdev, =?unknown-8bit?B?U8OpZ3VpZXIgUsOpZ2lz?=,
HaraldWelte, JoeyZhuo, AJJiang, BruceChang, WaltonLi
Andrew Morton <akpm@linux-foundation•org> :
[...]
> Is this a bugfix, a regression fix or a feature?
It is not a regression fix. I would say thet it is somewhere between
the bugfix and the feature.
>
> I assume that it was authored by Joey ?
Yes.
--
Ueimor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets
2008-11-07 22:36 [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets Francois Romieu
2008-11-07 22:49 ` Andrew Morton
@ 2008-11-07 22:51 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-11-07 22:51 UTC (permalink / raw)
To: Francois Romieu
Cc: jgarzik, netdev, Séguier Régis, HaraldWelte, JoeyZhuo,
AJJiang, BruceChang, WaltonLi
On Fri, 7 Nov 2008 23:36:17 +0100 Francois Romieu <romieu@fr•zoreil.com> wrote:
> Signed-off-by: Joey Zhuo <joeyzhuo@via•com.tw>
> Acked-off-by: Francois Romieu <romieu@fr•zoreil.com>
ooh, we need a Hacked-off-by too :)
I guess you meant Acked-by:, but as you were on the delivery path for
this patch, a Signed-off-by: is more appropriate.
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -2296,7 +2296,7 @@ static void velocity_set_multi(struct net_device *dev)
> }
>
> mac_set_cam_mask(regs, vptr->mCAMmask);
> - rx_mode = (RCR_AM | RCR_AB);
> + rx_mode = RCR_AM | RCR_AB | RCR_AP;
> }
> if (dev->mtu > 1500)
> rx_mode |= RCR_AL;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-07 23:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-07 22:36 [PATCH 1/1] via-velocity: enable perfect filtering for multicast packets Francois Romieu
2008-11-07 22:49 ` Andrew Morton
2008-11-07 23:03 ` Francois Romieu
2008-11-07 22:51 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox