public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse•de>
To: linux-kernel@vger•kernel.org, stable@kernel•org
Cc: Justin Forbes <jmforbes@linuxtx•org>,
	Zwane Mwaikambo <zwane@arm•linux.org.uk>,
	Theodore Ts'o <tytso@mit•edu>,
	Randy Dunlap <rdunlap@xenotime•net>,
	Dave Jones <davej@redhat•com>,
	Chuck Wolber <chuckw@quantumlinux•com>,
	Chris Wedgwood <reviews@ml•cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv•org>,
	Chuck Ebbert <cebbert@redhat•com>,
	Domenico Andreoli <cavokz@gmail•com>, Willy Tarreau <w@1wt•eu>,
	Rodrigo Rubira Branco <rbranco@la•checkpoint.com>,
	Jake Edge <jake@lwn•net>, Eugene Teo <eteo@redhat•com>,
	torvalds@linux-foundation•org, akpm@linux-foundation•org,
	alan@lxorguk•ukuu.org.uk, netdev@vger•kernel.org,
	netfilter-devel@vger•kernel.org,
	Patrick McHardy <kaber@trash•net>,
	davem@davemloft•net, Eric Leblond <eric@inl•fr>
Subject: [patch 45/48] netfilter: fix tuple inversion for Node information request
Date: Fri, 13 Feb 2009 17:13:51 -0800	[thread overview]
Message-ID: <20090214011351.GT17706@kroah.com> (raw)
In-Reply-To: <20090214011208.GA17706@kroah.com>

[-- Attachment #1: netfilter-fix-tuple-inversion-for-node-information-request.patch --]
[-- Type: text/plain, Size: 1309 bytes --]

2.6.28-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Eric Leblond <eric@inl•fr>

netfilter: fix tuple inversion for Node information request

Upstream commit: a51f42f3c

The patch fixes a typo in the inverse mapping of Node Information
request. Following draft-ietf-ipngwg-icmp-name-lookups-09, "Querier"
sends a type 139 (ICMPV6_NI_QUERY) packet to "Responder" which answer
with a type 140 (ICMPV6_NI_REPLY) packet.

Signed-off-by: Eric Leblond <eric@inl•fr>
Signed-off-by: Patrick McHardy <kaber@trash•net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse•de>

---
 net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
+++ b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
@@ -49,8 +49,8 @@ static bool icmpv6_pkt_to_tuple(const st
 static const u_int8_t invmap[] = {
 	[ICMPV6_ECHO_REQUEST - 128]	= ICMPV6_ECHO_REPLY + 1,
 	[ICMPV6_ECHO_REPLY - 128]	= ICMPV6_ECHO_REQUEST + 1,
-	[ICMPV6_NI_QUERY - 128]		= ICMPV6_NI_QUERY + 1,
-	[ICMPV6_NI_REPLY - 128]		= ICMPV6_NI_REPLY +1
+	[ICMPV6_NI_QUERY - 128]		= ICMPV6_NI_REPLY + 1,
+	[ICMPV6_NI_REPLY - 128]		= ICMPV6_NI_QUERY +1
 };
 
 static bool icmpv6_invert_tuple(struct nf_conntrack_tuple *tuple,


       reply	other threads:[~2009-02-14  1:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090214010805.419403436@mini.kroah.org>
     [not found] ` <20090214011208.GA17706@kroah.com>
2009-02-14  1:13   ` Greg KH [this message]
2009-02-14  1:13   ` [patch 46/48] netfilter: xt_sctp: sctp chunk mapping doesnt work Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090214011351.GT17706@kroah.com \
    --to=gregkh@suse$(echo .)de \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=cavokz@gmail$(echo .)com \
    --cc=cebbert@redhat$(echo .)com \
    --cc=chuckw@quantumlinux$(echo .)com \
    --cc=davej@redhat$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric@inl$(echo .)fr \
    --cc=eteo@redhat$(echo .)com \
    --cc=jake@lwn$(echo .)net \
    --cc=jmforbes@linuxtx$(echo .)org \
    --cc=kaber@trash$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=mkrufky@linuxtv$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=rbranco@la$(echo .)checkpoint.com \
    --cc=rdunlap@xenotime$(echo .)net \
    --cc=reviews@ml$(echo .)cw.f00f.org \
    --cc=stable@kernel$(echo .)org \
    --cc=torvalds@linux-foundation$(echo .)org \
    --cc=tytso@mit$(echo .)edu \
    --cc=w@1wt$(echo .)eu \
    --cc=zwane@arm$(echo .)linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox