public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse•de>
To: linux-kernel@vger•kernel.org, stable@kernel•org
Cc: Justin Forbes <jmforbes@linuxtx•org>,
	Zwane Mwaikambo <zwane@arm•linux.org.uk>,
	Theodore Ts'o <tytso@mit•edu>,
	Randy Dunlap <rdunlap@xenotime•net>,
	Dave Jones <davej@redhat•com>,
	Chuck Wolber <chuckw@quantumlinux•com>,
	Chris Wedgwood <reviews@ml•cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv•org>,
	Chuck Ebbert <cebbert@redhat•com>,
	Domenico Andreoli <cavokz@gmail•com>, Willy Tarreau <w@1wt•eu>,
	Rodrigo Rubira Branco <rbranco@la•checkpoint.com>,
	Jake Edge <jake@lwn•net>, Eugene Teo <eteo@redhat•com>,
	torvalds@linux-foundation•org, akpm@linux-foundation•org,
	alan@lxorguk•ukuu.org.uk, netdev@vger•kernel.org,
	netfilter-devel@vger•kernel.org,
	Patrick McHardy <kaber@trash•net>,
	davem@davemloft•net, Qu Haoran <haoran.qu@6wind•com>,
	Nicolas Dichtel <nicolas.dichtel@6wind•com>
Subject: [patch 46/48] netfilter: xt_sctp: sctp chunk mapping doesnt work
Date: Fri, 13 Feb 2009 17:13:53 -0800	[thread overview]
Message-ID: <20090214011353.GU17706@kroah.com> (raw)
In-Reply-To: <20090214011208.GA17706@kroah.com>

[-- Attachment #1: netfilter-xt_sctp-sctp-chunk-mapping-doesn-t-work.patch --]
[-- Type: text/plain, Size: 1026 bytes --]

2.6.28-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Qu Haoran <haoran.qu@6wind•com>

netfilter: xt_sctp: sctp chunk mapping doesn't work

Upstream commit: d4e2675a

When user tries to map all chunks given in argument, kernel
works on a copy of the chunkmap, but at the end it doesn't
check the copy, but the orginal one.

Signed-off-by: Qu Haoran <haoran.qu@6wind•com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Signed-off-by: Patrick McHardy <kaber@trash•net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse•de>

---
 net/netfilter/xt_sctp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/netfilter/xt_sctp.c
+++ b/net/netfilter/xt_sctp.c
@@ -105,7 +105,7 @@ match_packet(const struct sk_buff *skb,
 
 	switch (chunk_match_type) {
 	case SCTP_CHUNK_MATCH_ALL:
-		return SCTP_CHUNKMAP_IS_CLEAR(info->chunkmap);
+		return SCTP_CHUNKMAP_IS_CLEAR(chunkmapcopy);
 	case SCTP_CHUNK_MATCH_ANY:
 		return false;
 	case SCTP_CHUNK_MATCH_ONLY:


      parent reply	other threads:[~2009-02-14  1:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090214010805.419403436@mini.kroah.org>
     [not found] ` <20090214011208.GA17706@kroah.com>
2009-02-14  1:13   ` [patch 45/48] netfilter: fix tuple inversion for Node information request Greg KH
2009-02-14  1:13   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090214011353.GU17706@kroah.com \
    --to=gregkh@suse$(echo .)de \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=alan@lxorguk$(echo .)ukuu.org.uk \
    --cc=cavokz@gmail$(echo .)com \
    --cc=cebbert@redhat$(echo .)com \
    --cc=chuckw@quantumlinux$(echo .)com \
    --cc=davej@redhat$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=eteo@redhat$(echo .)com \
    --cc=haoran.qu@6wind$(echo .)com \
    --cc=jake@lwn$(echo .)net \
    --cc=jmforbes@linuxtx$(echo .)org \
    --cc=kaber@trash$(echo .)net \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=mkrufky@linuxtv$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=nicolas.dichtel@6wind$(echo .)com \
    --cc=rbranco@la$(echo .)checkpoint.com \
    --cc=rdunlap@xenotime$(echo .)net \
    --cc=reviews@ml$(echo .)cw.f00f.org \
    --cc=stable@kernel$(echo .)org \
    --cc=torvalds@linux-foundation$(echo .)org \
    --cc=tytso@mit$(echo .)edu \
    --cc=w@1wt$(echo .)eu \
    --cc=zwane@arm$(echo .)linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox