From: Rusty Russell <rusty@rustcorp•com.au>
To: Mark McLoughlin <markmc@redhat•com>
Cc: dlaor@redhat•com, netdev@vger•kernel.org,
Dor Laor <dor@redhat•com>, Avi Kivity <avi@redhat•com>,
virtualization@lists•linux-foundation.org
Subject: Re: [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC)
Date: Tue, 12 May 2009 23:53:53 +0930 [thread overview]
Message-ID: <200905122353.54424.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1242061838.25337.8.camel@blaa>
On Tue, 12 May 2009 02:40:38 am Mark McLoughlin wrote:
> > Blocked from doing the simpler thing, we've decided to go with a layer
> > of indirection. But the patch is simple and clean, so there's nothing
> > fundamental to object to.
>
> Still have one FIXME in the patch worth looking at - at what point
> should we use an indirect entry rather than consuming N entries?
OK, I've applied these as is. I'm doing some virtio net benchmarking (under
lguest); I'll see if I can get a reasonable figure. I don't think there's an
obvious right answer; it depends how many more packets are coming as well as
how many descriptors each will use.
Thanks,
Rusty.
next prev parent reply other threads:[~2009-05-12 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1229620222-22216-1-git-send-email-markmc@redhat.com>
[not found] ` <1229620222-22216-2-git-send-email-markmc@redhat.com>
[not found] ` <1229620222-22216-3-git-send-email-markmc@redhat.com>
2009-04-21 12:59 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Mark McLoughlin
2009-04-27 7:43 ` Dor Laor
2009-05-04 2:19 ` Rusty Russell
2009-05-11 17:10 ` Mark McLoughlin
2009-05-11 17:11 ` [PATCH 1/3] virtio: teach virtio_has_feature() about transport features Mark McLoughlin
2009-05-11 17:11 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Mark McLoughlin
2009-05-11 17:11 ` [PATCH 3/3] lguest: add support for indirect ring entries Mark McLoughlin
2009-05-12 14:23 ` Rusty Russell [this message]
2009-05-17 2:04 ` [PATCH 2/3] virtio: indirect ring entries (VIRTIO_RING_F_INDIRECT_DESC) Rusty Russell
2009-05-17 6:27 ` Avi Kivity
2009-05-17 14:16 ` Rusty Russell
2009-05-17 15:05 ` Avi Kivity
2009-05-19 8:15 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905122353.54424.rusty@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=avi@redhat$(echo .)com \
--cc=dlaor@redhat$(echo .)com \
--cc=dor@redhat$(echo .)com \
--cc=markmc@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox