public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft•net>
To: lgrijincu@ixiacom•com
Cc: netdev@vger•kernel.org, eric.dumazet@gmail•com
Subject: Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members
Date: Mon, 27 Jul 2009 08:26:44 -0700 (PDT)	[thread overview]
Message-ID: <20090727.082644.265102452.davem@davemloft.net> (raw)
In-Reply-To: <4A6DC314.2010303@ixiacom.com>

From: Lucian Adrian Grijincu <lgrijincu@ixiacom•com>
Date: Mon, 27 Jul 2009 18:09:08 +0300

> Some members of net_device are used only by some protocols.
> 
> If those protocols are not compiled (as modules or linked in) they
> should not take up space in the structure.

This benefits, at best, %0.000000001 of users of the Linux kernel,
because every distribution is going to turn on every single option.

If you want to shrink structures, find ways to eliminate or
shrink structure members in all cases.

I'm not applying this.

  reply	other threads:[~2009-07-27 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-27 15:09 [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members Lucian Adrian Grijincu
2009-07-27 15:26 ` David Miller [this message]
2009-07-27 16:23   ` Joe Perches
2009-07-27 16:27     ` David Miller
2009-07-27 16:33       ` Joe Perches
2009-07-28 14:43   ` Octavian Purdila
2009-07-28 16:49     ` Joe Perches
2009-07-29 14:20       ` Octavian Purdila
2009-07-28 17:28     ` David Miller
2009-07-29 10:31       ` Octavian Purdila
2009-07-28  6:57 ` Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090727.082644.265102452.davem@davemloft.net \
    --to=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=lgrijincu@ixiacom$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox