From: Octavian Purdila <opurdila@ixiacom•com>
To: Joe Perches <joe@perches•com>
Cc: David Miller <davem@davemloft•net>,
lgrijincu@ixiacom•com, netdev@vger•kernel.org,
eric.dumazet@gmail•com
Subject: Re: [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members
Date: Wed, 29 Jul 2009 17:20:09 +0300 [thread overview]
Message-ID: <200907291720.09704.opurdila@ixiacom.com> (raw)
In-Reply-To: <1248799755.6163.70.camel@Joe-Laptop.home>
On Tuesday 28 July 2009 19:49:15 Joe Perches wrote:
> > We are looking into that as well since we have a pretty aggressive goal
> > (get net_device to 450 bytes or so), but we thought of starting with the
> > low hanging fruits.
> > Any suggestions in this area?
>
> Some maybe not so good ones:
>
> Perhaps:
> struct timer_list watchdog_timer;
> might become a
> struct timer_list *watchdog_timer;
>
> Maybe all the protocol/mac/bridge/vlan/garp/wireless specific
> pointers might become a pointer to a list or array of pointers
> allocated on demand.
>
> Maybe combine perm_addr/broadcast/mc_list/uc addresses into a
> single list with type information. Maybe include dev_addrs,
> but it's iterated with an rcu lock held.
>
> Gaining less than 0, except maybe for weird network testing devices,
> use a pointer to struct net_device_stats.
Thanks for the suggestions.
BTW, we've noticed that the biggest net_device consumer is struct device with
176 bytes consumed on our arch (powerpc) and the only things that are used
from it seems to be the numa node id and the driver name. Some drivers also
use it but most of the usage seems to be related to sysfs.
Do you think its worth trying to make dev dependent on CONFIG_SYSFS?
tavi
next prev parent reply other threads:[~2009-07-29 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 15:09 [PATCH] net: shrink net_device by #ifdef-ing protocol-specific members Lucian Adrian Grijincu
2009-07-27 15:26 ` David Miller
2009-07-27 16:23 ` Joe Perches
2009-07-27 16:27 ` David Miller
2009-07-27 16:33 ` Joe Perches
2009-07-28 14:43 ` Octavian Purdila
2009-07-28 16:49 ` Joe Perches
2009-07-29 14:20 ` Octavian Purdila [this message]
2009-07-28 17:28 ` David Miller
2009-07-29 10:31 ` Octavian Purdila
2009-07-28 6:57 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907291720.09704.opurdila@ixiacom.com \
--to=opurdila@ixiacom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=lgrijincu@ixiacom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox