From: Jesper Nilsson <Jesper.Nilsson@axis•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: Jeff Garzik <jeff@garzik•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] Update embedded copy of ethtool.h from kernel 2.6.30
Date: Tue, 1 Dec 2009 16:42:46 +0100 [thread overview]
Message-ID: <20091201154246.GH5694@axis.com> (raw)
In-Reply-To: <1259680878.2831.3.camel@achroite.uk.solarflarecom.com>
On Tue, Dec 01, 2009 at 04:21:18PM +0100, Ben Hutchings wrote:
> On Tue, 2009-12-01 at 16:17 +0100, Jesper Nilsson wrote:
> > Commit 0c09c1a49cc7b819b33566a49d9901f7cfdd6889 in the Linux kernel
> > added a new field mdio_support inside the struct ethtool_cmd,
> > changing the struct size for architectures that does not pad structs.
> > (for example the CRIS architecture)
>
> CRIS has no alignment requirements?! Wow.
Yep, we don't even have the choice of adding padding inside structs. :-(
> Sorry for changing the
> structure, then.
We're used to tripping over this kind of thing. :-)
> > This size mismatch lead to the ethtool_cmd struct being written
> > as 44 bytes in the kernel, but only 43 bytes allocated on stack,
> > overwriting one byte in the stack frame.
> >
> > Update the ethtool copy of the definition to match the 2.6.30 kernel.
> [...]
>
> This has already been done.
Ah? Could someone point me to the correct git-tree for ethtool then?
I've been using http://www.kernel.org/pub/scm/network/ethtool/ethtool.git
which still has this problem...
> Ben.
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis•com
next prev parent reply other threads:[~2009-12-01 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 15:17 [PATCH] Update embedded copy of ethtool.h from kernel 2.6.30 Jesper Nilsson
2009-12-01 15:21 ` Ben Hutchings
2009-12-01 15:42 ` Jesper Nilsson [this message]
2009-12-01 15:52 ` Ben Hutchings
2009-12-01 15:54 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091201154246.GH5694@axis.com \
--to=jesper.nilsson@axis$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=jeff@garzik$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox