public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: David Miller <davem@davemloft•net>
To: anemo@mba•ocn.ne.jp
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call
Date: Fri, 26 Feb 2010 01:51:38 -0800 (PST)	[thread overview]
Message-ID: <20100226.015138.00843007.davem@davemloft.net> (raw)
In-Reply-To: <1267027217-7812-1-git-send-email-anemo@mba.ocn.ne.jp>

From: Atsushi Nemoto <anemo@mba•ocn.ne.jp>
Date: Thu, 25 Feb 2010 01:00:17 +0900

> The netif_wake_queue() is called correctly (i.e. only on !txfull
> condition) from net_tx().  So Unconditional call to the
> netif_wake_queue() here is wrong.  This might cause calling of
> start_xmit routine on txfull state and trigger tx-ring overflow.
> 
> This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba•ocn.ne.jp>

Applied.

Please reference commits by also making mention of the commit
log message header line.  This way when a patch is backported
into another tree, people can still find it even if the
SHA1 ID is different.  For exmaple, I fixed the above to
read:

    This fix is ported from commit 662a96bd6f020782dfbdc0d0bd177c7dbb556687
    ("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").

Thanks.

next prev parent reply	other threads:[~2010-02-26  9:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 16:00 [PATCH] isa-skelton: Remove a wrong netif_wake_queue() call Atsushi Nemoto
2010-02-26  9:51 ` David Miller [this message]
2010-02-26 16:13   ` Atsushi Nemoto
2010-02-26 17:03 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226.015138.00843007.davem@davemloft.net \
    --to=davem@davemloft$(echo .)net \
    --cc=anemo@mba$(echo .)ocn.ne.jp \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox